MC-9841 Update UI to support certain actions that can run async in Mauro #562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesrwelch
previously requested changes
Jul 19, 2022
|
Updated as best I can by rendering the async job messages as HTML:
This does produce a useable hyperlink which triggers a download. But we can't have a dedicated button for this because the async job details returned from Mauro do not provide any further context - such as the domain export ID that it is linked to, or additional context extracted from the message. |
* Update fork/branch/version of models to allow asynchronous creation * Update versioned folders to support async fork/branch/version * Updates to Import Models page * Add async option to Export Models page * Update model detail pages to support exports. Use a dialog to select export options now. * Prevent export models from mixing domain types in model selection * Use mdm-download-links component for Export Models page * Update infrastructure code to get correct MDM resource easier * Refactor other related code for type correctness
pjmonks
force-pushed
the
feature/mc-9841
branch
from
7ed7005
to
e3fae7f
Compare
pjmonks
dismissed
jamesrwelch’s stale review
Attempted to address some of the feedback, need it re-reviewed.
|
@pjmonks Minor question / comment - when I download a file using the new link, it opens a new blank browser tab at the same time as downloading. Is that to do with my browser? |
jamesrwelch
approved these changes
Aug 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
All async actions will display an info toast, if successful, stating the background job has started.
Screenshots
Branching/versioning/forking:
Export model (from model detail - new dialog):
Export models (multiple):
Import models - parameters pulled directly from importer plugin: