#567 - Confirm closing of certain dialogs when clicking in the overlay area #568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Any dialog that could potentially lose user input data is now wrapped around the EditingService to ask the user to confirm closing the dialog if they click in the overlay container/background
* Added necessary unsubscribe logic back to versioned folder * Removed unecessary unsubscribe logic from folder
jamesrwelch
approved these changes
Jul 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #567
For certain dialogs which allow a user to enter input, this PR now wraps those around the
EditingServiceto ensure that, if the user clicks outside the dialog (the overlay container), the user must confirm if they want to close the dialog before continuing.Whilst fixing these files, I have also worked through the eslint warnings in them to make them pass linting rules.