Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-570 Fix search reset bug which sticks on loading screen #575

Merged
merged 1 commit into from
Jul 4, 2022

Conversation

pjmonks
Copy link
Contributor

@pjmonks pjmonks commented Jun 29, 2022

Fixes #570

Due to the way the UI Router works when it decides no transition between routes is required, the loading screen was accidentally kept on preventing the user from doing anything else. This PR resolves that issue.

Copy link
Contributor

@aaronforshaw aaronforshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent 👍

@pjmonks pjmonks merged commit d436ee1 into develop Jul 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Catalogue item search can hang
2 participants