gh-590 Change architecture of bulk editor #602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Create new service layer between components and Mauro REST API Also added general fixes to bulk editor * Remove mix and match of Angular forms and reactive forms binding * Fix template error when parent data model not loaded yet * Fetch all data elements, not just first 20 gh-590 PR fixes
OButlerOcc
approved these changes
Jul 11, 2022
| @@ -42,6 +55,8 @@ export class BulkEditSelectComponent implements OnInit { | |||
| availableProfiles: ProfileSummary[]; | |||
| setupForm: FormGroup; | |||
|
|
|||
| private unsubscribe$ = new Subject(); | |||
There was a problem hiding this comment.
can you explain this to me if you have time, its seems useful and I think i get whats its doing but I would like to know how its working.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also added general fixes to bulk editor
Resolves #590