MC-9891 Update subscribed catalogue UI due to breaking core changes #612
Conversation
There was a problem hiding this comment.
Thanks for the PR @pjmonks.
I'm testing this by using develop of mdm-core, feature/mc-9681 of mdm-ui and mdm-resources.
I have been able to use the UI to add a Mauro JSON subscription to https://modelcatalogue.cs.ox.ac.uk/continuous-deployment and use the new modal to subscribe to a model.
There's an issue when viewing published models when connecting to an Atom catalogue however, I'm testing using an Atom subscription to https://modelcatalogue.cs.ox.ac.uk/continuous-deployment/api/feeds/all (with an API key).
I can see a list of published models in the tree on the left hand side of the UI, however when selecting these models a Not Found error appears in the main panel. Could you have a look at this?
N.B. When subscribing to an Atom catalogue, the modelIds returned in the /publishedModels and other endpoints will be unique but are not of any particular format as they come from the Atom source. In the Mauro Atom subscribed catalogue they are of the form urn:uuid:<UUID> but in general they could be any string. I'm wondering if this may be causing the issue.
|
I've noticed the backend error text isn't very user friendly when selecting an incompatible model content type and importer to subscribe to, I'll try to update this. |
|
Also looking at the published models ordering on the backend as that seems out of order. |
* Update admin setup forms to use Angular reactive forms * Add new connection type field to add/edit subscribed catalogue * Display connection type of each subscribed catalogue in the list view * Handle case where published model type is not known * Display published data model dates * Update Subscribe Data Model dialog to use Angular reactive forms * Send additional properties during subscribed model creation - content link and/or importer
* Remove checks for UUID model IDs, there are no longer guarantees the model ID of a published model is in this format * Display Catalogue type and URL when viewing a Subscribed Catalogue from the model tree
* Remove error triggered by trying to redirect to a data model, this was unnecessary * Removed newer versions table error on having two columns sortable by same key
joe-crawford
force-pushed
the
feature/mc-9891
branch
from
4f0a99b
to
d8bb290
Compare
Note: this depends on MauroDataMapper/mdm-resources#71
Screenshots
Admin screen of subscribed catalogues with subscribed catalogue types:
Inclusion of dates from published data models:
Updates to subscribe dialog: