Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/gh 518 sonarqube #613

Merged
merged 7 commits into from
Jul 22, 2022
Merged

Feature/gh 518 sonarqube #613

merged 7 commits into from
Jul 22, 2022

Conversation

OButlerOcc
Copy link
Contributor

Made changes suggested to clean up the major bugs on sonarqube
Not sure how to test the formatting for async-job-detail table changes.
The rest is tested

@pjmonks pjmonks self-requested a review July 22, 2022 09:37
@pjmonks pjmonks self-assigned this Jul 22, 2022
@pjmonks pjmonks linked an issue Jul 22, 2022 that may be closed by this pull request
Copy link
Contributor

@pjmonks pjmonks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've pushed some of my own changes, but these now bring the Sonarqube bug list down to zero, I've confirmed this by testing this branch.

Well done 👍

@pjmonks pjmonks merged commit 8d934fb into develop Jul 22, 2022
@pjmonks pjmonks deleted the feature/gh-518-sonarqube branch July 22, 2022 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix remaining Sonarqube major bugs identified
2 participants