Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-585 - Edit Markdown and HTML text in the bulk editor #629

Merged
merged 7 commits into from
Aug 1, 2022
Merged

gh-585 - Edit Markdown and HTML text in the bulk editor #629

merged 7 commits into from
Aug 1, 2022

Conversation

pjmonks
Copy link
Contributor

@pjmonks pjmonks commented Jul 29, 2022

Resolves #585

Updates the bulk editor to support full Markdown and HTML editing on any profile field that has the type text - the description field in the "Default profile" is a good example.

  • Uses a basic popup cell editor for basic text edits within the cell, as expected for agGrid.
  • There is then a "pop out" button to expand the cell value into a separate dialog. This gives full editor control over the Markdown/HTML text.

Screenshots

image

image

OButlerOcc
OButlerOcc previously approved these changes Aug 1, 2022
View reviewed changes
Copy link
Contributor

@OButlerOcc OButlerOcc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Easy to follow, this one. Works as far as I've poked it locally. I've noticed we're having to non standardise a few column options now we're using custom components I wonder if there's a smarter way to do that.

src/app/bulk-edit/bulk-edit-editor/bulk-edit-editor.component.ts
this.gridColumnApi.autoSizeColumns(columnIds);

this.nonStandardColWidths
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've got a method for non standard col resizable, if we need more of these may be worth structuring as something we can dynamically adjust via properties or something?

@pjmonks
gh-585 Experiment with ag grid markdown cell editor
6d9c819 
* Initial test to see what this looks like and how useable it is
* Not complete, but basics are available
@pjmonks
gh-585 Experiment with agGrid overlays for editing text
f5e728a
@pjmonks
gh-585 Experiment with Excel-like singular text editor
9a1cffd
@pjmonks
gh-585 Remove failed experiments
2a6f30a 
* Popup cell editor
* Excel-like controls
@pjmonks
gh-585 Create custom text area cell editor
5984830 
* Similar to built in ag Grid version but includes hint about creating new lines
* Also includes "Edit" button, this will trigger a larger content editor to appear
@pjmonks
gh-585 Create custom dialog for full text editing of a cell
ac08168 
* Trigger via button click in TextAreaCellEditorComponent
* Open dialog with MDM content editor
* Resize all columns correctly
* Remove agGrid overlay code
@pjmonks
gh-585 PR checks
4cd6542
@pjmonks pjmonks requested a review from OButlerOcc August 1, 2022 13:39
OButlerOcc
OButlerOcc approved these changes Aug 1, 2022
View reviewed changes
Copy link
Contributor

@OButlerOcc OButlerOcc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't see any changes from last time after rebase

@pjmonks pjmonks merged commit b8b1516 into develop Aug 1, 2022
@pjmonks pjmonks deleted the feature/gh-585 branch August 1, 2022 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OButlerOcc OButlerOcc OButlerOcc approved these changes

@jamesrwelch jamesrwelch Awaiting requested review from jamesrwelch

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable the HTML / MD editor on text fields within the profile editor
2 participants
@pjmonks @OButlerOcc