Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display description column on term list #631

Merged
merged 2 commits into from
Aug 4, 2022
Merged

Display description column on term list #631

merged 2 commits into from
Aug 4, 2022

Conversation

jamesrwelch
Copy link
Contributor

Fix for #546

@pjmonks pjmonks linked an issue Aug 4, 2022 that may be closed by this pull request
@pjmonks pjmonks self-assigned this Aug 4, 2022
Copy link
Contributor

@pjmonks pjmonks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks good. I noticed when using the "Description" column filter that it wasn't filtering the terms list. I don't think this is an issue with the UI though, it looks like you've wired everything correctly and the HTTP requests happen and look correct, I think this is a backend bug.

Approved ✔️

@pjmonks pjmonks merged commit 91cf635 into develop Aug 4, 2022
@pjmonks pjmonks deleted the feature/gh-546 branch August 4, 2022 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add 'description' to the term list in a terminology
2 participants