Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated messages dynamic mesage added if filter on #647

Merged
merged 4 commits into from
Sep 8, 2022

Conversation

OButlerOcc
Copy link
Contributor

message changes when filters are enabled and no items are available

@OButlerOcc OButlerOcc linked an issue Aug 18, 2022 that may be closed by this pull request
@pjmonks pjmonks self-requested a review August 30, 2022 11:07
Copy link
Contributor

@pjmonks pjmonks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please could some of the messages be re-worded, otherwise it looks good.

src/app/admin/emails/emails.component.html Outdated Show resolved Hide resolved
src/app/userArea/api-keys/api-keys.component.html Outdated Show resolved Hide resolved
Copy link
Contributor

@pjmonks pjmonks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good 👍

@pjmonks pjmonks merged commit 1950ca0 into develop Sep 8, 2022
@pjmonks pjmonks deleted the feature/gh-383-message branch September 8, 2022 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change messages when no items are in a table
2 participants