Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-492 Display version and branch name of terminology when selecting for Code Sets #652

Merged
merged 4 commits into from
Sep 5, 2022

Conversation

pjmonks
Copy link
Contributor

@pjmonks pjmonks commented Sep 2, 2022

Resolves #492

image

@jamesrwelch
Copy link
Contributor

This is brilliant - could we roll this out easily to other places too - for example when we create model data types? Is there an easy way to find other similar model drop-downs?

pjmonks and others added 2 commits September 5, 2022 10:34
* Make labels that show branch/version a shared component
* Re-use label component in additional places where it's useful to show - Favourites tree, Data Type wizard, Element Selector dialog
@pjmonks
Copy link
Contributor Author

pjmonks commented Sep 5, 2022

@jamesrwelch I've updated other areas which use a similar control:

image

I've updated the New Data Type wizard and the Element Selector (links for description fields).

Now that the label with branch/version is a shared component I've also looked at the tree views too. The new Favourites tree is updated but not the main model tree - too complex to fiddle with at the moment.

@jamesrwelch
Copy link
Contributor

This looks great - I've made a minor tweak that I found when testing - making sure to load all results rather than paginating. Will accept when the build has gone through

Copy link
Contributor

@jamesrwelch jamesrwelch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works really nicely - thank you!

@jamesrwelch jamesrwelch merged commit 66c35ab into develop Sep 5, 2022
@jamesrwelch jamesrwelch deleted the feature/gh-492 branch September 5, 2022 12:37
@jamesrwelch jamesrwelch added this to the 7.3.0 milestone Sep 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

List Version no. alongside terminology name when creating a new codeset
2 participants