gh-680 Make footer stick to bottom of page #692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- When page contains additional space in content, footer will also attach to the bottom of the screen - If the page height requires vertical scrolling, footer will always be at the end of the page - Remove model tree forced height
jamesrwelch
force-pushed
the
feature/gh-680
branch
from
6c4629f
to
37b4de9
Compare
jamesrwelch
approved these changes
Nov 30, 2022
There was a problem hiding this comment.
Beautifully sticky, thank you!
I wonder whether the styling in the div in src/app/shared/models/models.component.html should be in a css file, but maybe there's another issue to be raised for moving all styling into css files rather than in the tags themselves.
I'll accept this and enjoy the extra whitespace in the middle of the screen!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #680