Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-739 Fix Bulk Editor cancel action #743

Merged
merged 2 commits into from
Feb 1, 2023
Merged

gh-739 Fix Bulk Editor cancel action #743

merged 2 commits into from
Feb 1, 2023

Conversation

pjmonks
Copy link
Contributor

@pjmonks pjmonks commented Jan 27, 2023

Manually confirm with user they want to cancel and go back a page if they confirm.

Fixes #739

Manually confirm with user they want to cancel and go back a page if they confirm
Copy link
Contributor

@jamesrwelch jamesrwelch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely stuff - it was a good catch in the first place. The code looks good; I've had a play and can't break it. 10/10 - would buy again.

@jamesrwelch jamesrwelch merged commit 2411e15 into develop Feb 1, 2023
@jamesrwelch jamesrwelch deleted the feature/gh-739 branch February 1, 2023 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Post Angular 14 upgrade] Cannot cancel and go back in Bulk Editor
2 participants