gh-755 Refactor group-access-new component #758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use stricter typing on endpoints and lists used - Rename properties to make more sense - Rename table columns - Update add/delete options for managing securable resource groups - Fix issue where selecting options when adding new groups does not work, replace custom controls with MatSelect
joe-crawford
approved these changes
Feb 17, 2023
There was a problem hiding this comment.
Great, thanks for this @pjmonks, this looks good to me and works well locally 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: depends on MauroDataMapper/mdm-resources#96 first
Fixes #755