Merge pull request #929 from Mause/fix-domains

fix: _loads_domains in SQLA2
Mause · Apr 7, 2024 · 272a300 · 272a300
2 parents e2055f9 + 4c67e26
commit 272a300
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/duckdb_engine/__init__.py b/duckdb_engine/__init__.py
@@ -561,12 +561,16 @@ def get_multi_columns(
 
         # dictionary with (name, ) if default search path or (schema, name)
         # as keys
+        domains: Dict[tuple, dict] = {}
+        """
+        TODO: fix these pg_collation errors in SQLA2
         domains = {
             ((d["schema"], d["name"]) if not d["visible"] else (d["name"],)): d
             for d in self._load_domains(  # type: ignore[attr-defined]
                 connection, schema="*", info_cache=kw.get("info_cache")
             )
         }
+        """
 
         # dictionary with (name, ) if default search path or (schema, name)
         # as keys