Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support SQLAlchemy < 1.4 without a deprecation warning on 1.4+ #219

Merged
merged 1 commit into from
Mar 13, 2022

Conversation

marcua
Copy link
Contributor

@marcua marcua commented Feb 6, 2022

Thanks for a great package! Here's a small tweak:

  • A recent PR introduced backward-compatibility for SQLAlchemy < 1.4
  • The replaced method is being deprecated and is causing deprecation warnings on newer versions of SQLAlchemy
  • The docs suggest an easy way to keep backward-compatibility without receiving deprecation warnings in future versions
  • This PR implements that suggestion
  • Note: I wasn't sure how to run tests---if there's anything I should do beyond what I've already done, let me know. Perhaps GH Actions will run tests in your repo?

@Mause
Copy link
Owner

Mause commented Mar 13, 2022

Many thanks for this!

@Mause Mause merged commit 0e8615e into Mause:master Mar 13, 2022
@marcua marcua deleted the sqlalchemy-1.4-compat branch March 13, 2022 13:34
@marcua
Copy link
Contributor Author

marcua commented Mar 13, 2022

Thank you so much @Mause!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants