Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SlickGrid applies highlight styles twice during render #20

Open
quigleyj-mavenomics opened this issue Oct 25, 2019 · 1 comment
Open
Labels
bug Something isn't working SlickGrid Anything to do with SlickGrid, the SlickGridPart, or TableEditorPart

Comments

@quigleyj-mavenomics
Copy link
Member

What's happening is a rather maddening interaction between the radio/checklists and the rest of the rendering cycle. The cell differ, after running, sets a changes property and triggers an update on the DataView. The grid then calls an onRowsChanged event, where we handle it by applying highlight CSS styles. Up to now, everything is happening as it's supposed to.

Where things get messy are in the Radio/Checklist runners in setPreviousSelection() that execute immediately afterwards. What they do is invalidate the entire grid (something that was already partially done during the cell highlight update), causing visible studder and showing the grid re-rendering highlights.

This is kinda tricky since the radios/checklists are hacked in there good, and are quite fragile.

Keywords; render twice, slickgrid, highlights, ticking, css

@quigleyj-mavenomics quigleyj-mavenomics added bug Something isn't working SlickGrid Anything to do with SlickGrid, the SlickGridPart, or TableEditorPart labels Oct 25, 2019
@YairMarcowMavenomics
Copy link
Contributor

We think this is probably in our wrapping and likely be fixed automatically by switching to the latest greatest ~6pac Slickgrid.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working SlickGrid Anything to do with SlickGrid, the SlickGridPart, or TableEditorPart
Projects
None yet
Development

No branches or pull requests

2 participants