Advanced search panel #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Max-Levitskiy
force-pushed
the
search-panel
branch
2 times, most recently
from
7d96c8c
to
4027327
Compare
Max-Levitskiy
force-pushed
the
search-panel
branch
from
4027327
to
79f0428
Compare
helloilya
reviewed
Oct 24, 2020
| } | ||
|
|
||
| ngOnDestroy(): void { | ||
| this.formSubscription?.unsubscribe(); |
There was a problem hiding this comment.
Don't need to check undefined. Just this.formSubscription.unsubscribe().
| .pipe( | ||
| startWith({}), | ||
| switchMap(() => { | ||
| switchMap((value) => { |
| <mat-label>Filter</mat-label> | ||
| <input matInput [ngrxFormControlState]="(form$ | async).controls.query" placeholder="Filter"/> | ||
| </mat-form-field> | ||
| <br/> |
There was a problem hiding this comment.
ok, I'll delete it.
| .pipe( | ||
| startWith({}), | ||
| switchMap(() => { | ||
| switchMap((value) => { | ||
| this.isLoadingResults = true; |
There was a problem hiding this comment.
You can use tap operator for this.isLoadingResults.
| .pipe( | ||
| startWith({}), | ||
| switchMap(() => { | ||
| switchMap((value) => { | ||
| this.isLoadingResults = true; | ||
| const queryParams: QueryParams = { |
There was a problem hiding this comment.
I'd move queryParams preparation for resourceService into map.
|
|
||
| resources: EsHits<Resource>[] = []; | ||
| resources: Observable<EsHits<Resource>[]>; |
There was a problem hiding this comment.
$ suffix is used to indicate observable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.