Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding SRI integrity to all fields. #561

Merged
merged 2 commits into from Aug 15, 2015
Merged

Adding SRI integrity to all fields. #561

merged 2 commits into from Aug 15, 2015

Conversation

jmervine
Copy link
Contributor

@jdorfman

  • Adding script to create integrity for any missing files in config/_config.yml.
    • This is now dynamically generated, as such, all comments, sorting and general formatting is now out the window.
  • Adding integrity to all fields.
  • Refactoring views and helpers to accommodate integrity.
  • Fixing tryIt pathing.

This is a fairly drastic change, as such, before merging I've deployed this branch here http://bootstrapcdn.herokuapp.com/.

@jdorfman
Copy link
Member

@jmervine if I merge this, it will only deploy to dev.bootstrap not www.bootstrap correct?

@jmervine
Copy link
Contributor Author

That's correct. But don't merge unless you actually want to release this, I released to a seperate location so we could review and discuss before moving forward.

@jdorfman
Copy link
Member

@jmervine can this be closed?

@jmervine
Copy link
Contributor Author

I'd like to merge it. Waiting for you to +1 it, it's such a major change.

@jdorfman
Copy link
Member

sorry +1

@jmervine
Copy link
Contributor Author

Cool. I'll try to merge and release this later this afternoon.
On Sat, Aug 15, 2015 at 08:42 Justin Dorfman notifications@github.com
wrote:

sorry +1


Reply to this email directly or view it on GitHub
#561 (comment).

jmervine and others added 2 commits August 15, 2015 11:30
Conflicts:
	config/_config.yml
	views/_partials/csscode.jade
	views/_partials/jscode.jade
jmervine added a commit that referenced this pull request Aug 15, 2015
Adding SRI integrity to all fields.
@jmervine jmervine merged commit 7f1b2e2 into develop Aug 15, 2015
@jmervine jmervine deleted the jmervine-sri branch August 15, 2015 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants