Tweaks #1172
Merged
Tweaks #1172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XhmikosR
force-pushed
the
develop-xmr-tests
branch
from
c1d4334
to
975bf72
Compare
Unfortunately, due to the way StackPath's CDN handles LRU cache, we can't test this. Although, we should definitely test it.
XhmikosR
force-pushed
the
develop-xmr-tests
branch
from
975bf72
to
758b92d
Compare
|
...and now we are getting timeouts, which is pretty bad. 15 seconds not enough to fetch files? We should probably reduce the timeout for all tests except maybe for the HTML validation checks which can be slow. The CDN should be instant, and we should expect this. |
jdorfman
approved these changes
Jun 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OK, this is getting ridiculous so I have no other choice than disabling the gzip tests. IMO, we should definitely test this. But unless SP changes how their LRU cache works, we can't.
Also, this PR tweaks CI testing by adapting to the new
npm cicommand.