Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lint #1265

Merged
merged 1 commit into from Jan 20, 2019
Merged

Lint #1265

merged 1 commit into from Jan 20, 2019

Conversation

XhmikosR
Copy link
Collaborator

I kept the url.parse() changes as a separate patch but I'll squash before the merge.

@jmervine jmervine temporarily deployed to bootstrapcdn-dev-pr-1265 January 14, 2019 19:51 Inactive
@XhmikosR
Copy link
Collaborator Author

Needs some more cleanup.

@jmervine jmervine temporarily deployed to bootstrapcdn-dev-pr-1265 January 18, 2019 11:31 Inactive
@XhmikosR
Copy link
Collaborator Author

@jmervine please review one more time. I basically split req.originalUrl in ? to keep only the pathname.

@jmervine jmervine temporarily deployed to bootstrapcdn-dev-pr-1265 January 18, 2019 15:54 Inactive
@XhmikosR
Lint and minor refactoring.
5783c9d 
Also, stop using the deprecated `url.parse()` function.
@XhmikosR XhmikosR merged commit 8d408ee into develop Jan 20, 2019
@XhmikosR XhmikosR deleted the develop-xmr-lint branch January 20, 2019 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmervine jmervine jmervine approved these changes

Assignees
No one assigned
Labels
in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@XhmikosR @jmervine