Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates #1290

Merged
merged 7 commits into from Mar 8, 2019
Merged

Updates #1290

merged 7 commits into from Mar 8, 2019

Conversation

XhmikosR
Copy link
Collaborator

@XhmikosR XhmikosR commented Mar 7, 2019

No description provided.

@jmervine jmervine temporarily deployed to bootstrapcdn-dev-pr-1290 March 7, 2019 23:02 Inactive
@jmervine jmervine temporarily deployed to bootstrapcdn-dev-pr-1290 March 7, 2019 23:06 Inactive
@jmervine jmervine temporarily deployed to bootstrapcdn-dev-pr-1290 March 7, 2019 23:08 Inactive
@jmervine jmervine temporarily deployed to bootstrapcdn-dev-pr-1290 March 7, 2019 23:24 Inactive
@jmervine jmervine temporarily deployed to bootstrapcdn-dev-pr-1290 March 7, 2019 23:25 Inactive
Since we do `require('assert').strict`, this is implied.
* mocha 6.x still doesn't work with our mocha.opts, so leave it to 5.x for the time being
* html-validator 4.x switched to async/await so stay with the old version for now
* lowercase hex values
* make it bigger
@XhmikosR XhmikosR changed the title WIP Updates Updates Mar 8, 2019
@XhmikosR XhmikosR marked this pull request as ready for review March 8, 2019 13:40
Copy link
Member

@jdorfman jdorfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, did StackPath ask you about the logo?

@XhmikosR
Copy link
Collaborator Author

XhmikosR commented Mar 8, 2019

No, but I thought we'd use it in its original size. Not sure why I went with 150px width in the first place, but it looks good bigger too.

@XhmikosR XhmikosR merged commit 58812da into develop Mar 8, 2019
@XhmikosR XhmikosR deleted the develop-xmr-update-mocha branch March 8, 2019 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants