Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Bootstrap 5.0.0-alpha1 #1580

Merged
merged 5 commits into from Jun 30, 2020
Merged

Add Bootstrap 5.0.0-alpha1 #1580

merged 5 commits into from Jun 30, 2020

Conversation

XhmikosR
Copy link
Collaborator

@XhmikosR XhmikosR commented Jun 18, 2020 •
edited

TODO:

  • List v5 in index with a warning
  • Use an npm package alias for bootstrap 5
  • Add the ESM JS build which is only present in v5
  • Don't add the latest (only one) v5 in Legacy page since we list it in the main page
  • Add tests

@jmervine jmervine temporarily deployed to bootstrapcdn-dev-pr-1580 June 18, 2020 13:38 Inactive
@XhmikosR XhmikosR temporarily deployed to bootstrapcdn-dev-pr-1580 June 18, 2020 14:09 Inactive
@XhmikosR XhmikosR temporarily deployed to bootstrapcdn-dev-pr-1580 June 23, 2020 13:31 Inactive
@XhmikosR XhmikosR temporarily deployed to bootstrapcdn-dev-pr-1580 June 23, 2020 13:33 Inactive
@XhmikosR XhmikosR temporarily deployed to bootstrapcdn-dev-pr-1580 June 23, 2020 13:39 Inactive
@XhmikosR XhmikosR temporarily deployed to bootstrapcdn-dev-pr-1580 June 23, 2020 16:14 Inactive
@XhmikosR XhmikosR temporarily deployed to bootstrapcdn-dev-pr-1580 June 23, 2020 16:24 Inactive
@XhmikosR XhmikosR temporarily deployed to bootstrapcdn-dev-pr-1580 June 23, 2020 16:47 Inactive
@XhmikosR XhmikosR temporarily deployed to bootstrapcdn-dev-pr-1580 June 24, 2020 05:43 Inactive
@XhmikosR XhmikosR temporarily deployed to bootstrapcdn-dev-pr-1580 June 24, 2020 05:49 Inactive
@XhmikosR XhmikosR temporarily deployed to bootstrapcdn-dev-pr-1580 June 25, 2020 11:52 Inactive
@XhmikosR XhmikosR temporarily deployed to bootstrapcdn-dev-pr-1580 June 25, 2020 11:58 Inactive
@XhmikosR
Copy link
Collaborator Author

@jmervine @jdorfman can you guys check the preview please? Does it look good to you?

@jdorfman
Copy link
Member

@XhmikosR when I go to https://bootstrapcdn-dev-pr-1580.herokuapp.com/

I see "There's nothing here, yet."

@XhmikosR
Copy link
Collaborator Author

Should be live again now.

@jdorfman
Copy link
Member

LGTM :shipit:

@jdorfman jdorfman marked this pull request as ready for review June 30, 2020 14:16
@XhmikosR XhmikosR merged commit 54c9d67 into develop Jun 30, 2020
@XhmikosR XhmikosR deleted the bootstrap-alpha1 branch June 30, 2020 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cdn www
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@XhmikosR @jdorfman @jmervine