Merging creack/cleanup - proposed v2

[jmervine]

Replacing #3 (cc @jdorfman)

@creack Merged your branch here, with the following changes...

• Adding Godeps to lock dependancies.
• Ensuring go 1.3 support, as it's latest stable for Debian (which is what I use).
• Adding LICENSE file (addressing Add LICENSE file #4)

---

Original PR notes:

Minor cleanup including:

• Add all example to godoc (rename example function)
• Discard travis tests for go < 1.4
• Use .PHONY rule in makefile
• comply to golint
• Use "standalone" structs instead of nested for easier testing
• Remove pointer on header because it is already a reference
• use http.Dump{Request,Response} instead of json.MarshalIndent
• remove unnecessary named returns
• remove unnecessary mutexes
• close channels when finished
• minor optimizations
• Add .gitignore

[creack]

This is wrong. it should still be "github.com/garyburd/go-oauth/oauth"

[jmervine]

That's a choice in how you use Godeps, I typically use this method, opting not to change the GOPATH. That import line was written directly by Godeps itself. If we use Godeps at all, I greatly prefer this method.

[creack]

The imports should be "regular", Godeps should not be part of the import paths.
Beside this: 👍

[jmervine]

RE Godeps, can you provide a little insight as to why you prefer using standard import paths? I've only read the docs and not had a chance to discuss the pros and cons of both with anyone. It seemed to me that the method I used with better/simpler for both development and building, but I'd genuinely love to hear the other side of it.

Cheers,
J

[creack]

Godep is a useful tool, but should be "hidden". The idea is to be 100% go with godep has a helper.

Forcing the import path to the godep subdir makes the import ugly but more importantly, forces the developer to use that version of the code. Which will be done anyway when using godep go build but having the "standard" import path allow the developer to use it's own version of the dependencies.

[jmervine]

Interesting, okay. I'll play around with that. I know there's some changes you have to make to the way travis works when attempting to use Godep without the Godep pathing.

[jdorfman]

looks good, @jmervine merge and push package whenever

[jmervine]

@jdorfman I'm merging this now. Keep in mind there's some minor breaking changes. If support gets any pings on it, point them to v1 via import "gopkg.in/jmervine/go-maxcdn.v1" or to to read the updated docs.

[jdorfman]

got it thanks @jmervine