Add properties for CALayer appearance #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #34 +/- ##
=======================================
Coverage 95.23% 95.23%
=======================================
Files 5 5
Lines 336 336
=======================================
Hits 320 320
Misses 16 16Continue to review full report at Codecov.
|
MaxDesiatov
changed the title
MaxDesiatov
requested changes
Feb 6, 2019
Example/Gluon/GluonApp.swift
Outdated
| } | ||
|
|
||
| static func render(props: Props, hooks: Hooks) -> AnyNode { | ||
| let left = hooks.state(0.5 as Float) |
There was a problem hiding this comment.
can you please rename this to a more sensible name, maybe just plain state? left doesn't seem like a good fit as it doesn't seem to be related to any position properties in any way
| style.opacity.flatMap { view.layer.opacity = $0 } | ||
| style.shadowColor.flatMap { view.layer.shadowColor = UIColor($0).cgColor } | ||
| style.shadowOpacity.flatMap { view.layer.shadowOpacity = $0 } | ||
| style.shadowRadius.flatMap { view.layer.shadowRadius = CGFloat($0) } |
There was a problem hiding this comment.
looks like masksToBounds is missing here
MaxDesiatov
approved these changes
Feb 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #30
Add: