Test make_time

MaxGekk · Sep 4, 2019 · 1d68f58 · 1d68f58
1 parent b67f270
commit 1d68f58
Show file tree

Hide file tree

Showing 3 changed files with 38 additions and 13 deletions.
diff --git a/sql/core/src/main/scala/org/apache/spark/sql/execution/HiveResult.scala b/sql/core/src/main/scala/org/apache/spark/sql/execution/HiveResult.scala
@@ -75,6 +75,7 @@ object HiveResult {
     ShortType,
     DateType,
     TimestampType,
+    TimeType,
     BinaryType)
 
   private lazy val dateFormatter = DateFormatter()

diff --git a/sql/core/src/test/resources/sql-tests/inputs/pgSQL/date.sql b/sql/core/src/test/resources/sql-tests/inputs/pgSQL/date.sql
@@ -350,12 +350,12 @@ SELECT DATE_TRUNC('DECADE', TO_DATE('0002-12-31 BC', 'yyyy-MM-dd G')); -- 0011-0
 select make_date(2013, 7, 15);
 -- [SPARK-28471] Formatting dates with negative years
 select make_date(-44, 3, 15);
--- select make_time(8, 20, 0.0);
+select make_time(8, 20, 0.0);
 -- should fail
 select make_date(2013, 2, 30);
 select make_date(2013, 13, 1);
 select make_date(2013, 11, -1);
--- select make_time(10, 55, 100.1);
--- select make_time(24, 0, 2.1);
+select make_time(10, 55, 100.1);
+select make_time(24, 0, 2.1);
 
 DROP TABLE DATE_TBL;
diff --git a/sql/core/src/test/resources/sql-tests/results/pgSQL/date.sql.out b/sql/core/src/test/resources/sql-tests/results/pgSQL/date.sql.out
@@ -1,5 +1,5 @@
 -- Automatically generated by SQLQueryTestSuite
--- Number of queries: 91
+-- Number of queries: 94
 
 
 -- !query 0
@@ -822,32 +822,56 @@ struct<make_date(-44, 3, 15):date>
 
 
 -- !query 87
-select make_date(2013, 2, 30)
+select make_time(8, 20, 0.0)
 -- !query 87 schema
-struct<make_date(2013, 2, 30):date>
+struct<make_time(8, 20, CAST(0.0 AS DECIMAL(8,6))):time>
 -- !query 87 output
-NULL
+08:20
 
 
 -- !query 88
-select make_date(2013, 13, 1)
+select make_date(2013, 2, 30)
 -- !query 88 schema
-struct<make_date(2013, 13, 1):date>
+struct<make_date(2013, 2, 30):date>
 -- !query 88 output
 NULL
 
 
 -- !query 89
-select make_date(2013, 11, -1)
+select make_date(2013, 13, 1)
 -- !query 89 schema
-struct<make_date(2013, 11, -1):date>
+struct<make_date(2013, 13, 1):date>
 -- !query 89 output
 NULL
 
 
 -- !query 90
-DROP TABLE DATE_TBL
+select make_date(2013, 11, -1)
 -- !query 90 schema
-struct<>
+struct<make_date(2013, 11, -1):date>
 -- !query 90 output
+NULL
+
+
+-- !query 91
+select make_time(10, 55, 100.1)
+-- !query 91 schema
+struct<make_time(10, 55, CAST(100.1 AS DECIMAL(8,6))):time>
+-- !query 91 output
+NULL
+
+
+-- !query 92
+select make_time(24, 0, 2.1)
+-- !query 92 schema
+struct<make_time(24, 0, CAST(2.1 AS DECIMAL(8,6))):time>
+-- !query 92 output
+NULL
+
+
+-- !query 93
+DROP TABLE DATE_TBL
+-- !query 93 schema
+struct<>
+-- !query 93 output