Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SavingIteratorTest.php:176-177: Remove usage of The, Let... #148

Closed
0pdd opened this issue Dec 4, 2021 · 1 comment
Closed

SavingIteratorTest.php:176-177: Remove usage of The, Let... #148

0pdd opened this issue Dec 4, 2021 · 1 comment
Assignees
@MaxGoryunov
Labels
bug Something isn't working

Comments

@0pdd
Copy link
Collaborator

0pdd commented Dec 4, 2021

The puzzle 129-e00ee433 from #129 has to be resolved:

saving-iterator/tests/src/SavingIteratorTest.php

Lines 176 to 177 in 4d17cde

* @todo #129:30min Remove usage of The, Let and redundant variables
* where RpIteratorToArray was introduced.

The puzzle was created by Max Goryunov on 29-Oct-21.

Estimate: 30 minutes, role: DEV.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.
@0pdd 0pdd added the bug Something isn't working label Dec 4, 2021
@MaxGoryunov MaxGoryunov self-assigned this Dec 4, 2021
MaxGoryunov added a commit that referenced this issue Dec 4, 2021
@MaxGoryunov
#148: removed The usage from tests with RpIteratorToArray
4a26390
@MaxGoryunov MaxGoryunov mentioned this issue Dec 4, 2021
Merged
@0pdd
Copy link
Collaborator Author

0pdd commented Dec 4, 2021

The puzzle 129-e00ee433 has disappeared from the source code, that's why I closed this issue.

@0pdd 0pdd closed this as completed Dec 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MaxGoryunov MaxGoryunov

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@0pdd @MaxGoryunov