Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SavingIteratorTest.php:19-20: It is needed to test that... #40

Closed
0pdd opened this issue Jul 25, 2021 · 3 comments
Closed

SavingIteratorTest.php:19-20: It is needed to test that... #40

0pdd opened this issue Jul 25, 2021 · 3 comments
Assignees
@MaxGoryunov
Labels
enhancement New feature or request

Comments

@0pdd
Copy link
Collaborator

0pdd commented Jul 25, 2021

The puzzle 8-efc308e6 from #8 has to be resolved:

saving-iterator/tests/src/SavingIteratorTest.php

Lines 19 to 20 in 0cbc706

* @todo #8:30min It is needed to test that `SavingIterator` works correctly
* with an empty Iterator.

The puzzle was created by Max Goryunov on 25-Jul-21.

Estimate: 30 minutes, role: DEV.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.
0pdd referenced this issue Jul 25, 2021
@MaxGoryunov
Merge pull request #39 from MaxGoryunov/feature/8
0cbc706 
Feature/8
@0pdd 0pdd mentioned this issue Jul 25, 2021
Closed
@MaxGoryunov MaxGoryunov self-assigned this Jul 25, 2021
MaxGoryunov added a commit that referenced this issue Jul 25, 2021
@MaxGoryunov
#40: added tests for empty iterators
530acd1
MaxGoryunov added a commit that referenced this issue Jul 25, 2021
@MaxGoryunov
#40: removed @todo marker
70341e5
@MaxGoryunov MaxGoryunov mentioned this issue Jul 26, 2021
Merged
MaxGoryunov added a commit that referenced this issue Jul 26, 2021
@MaxGoryunov
#40: removed @todo marker again
67d7301
@MaxGoryunov MaxGoryunov added the enhancement New feature or request label Jul 26, 2021
MaxGoryunov added a commit that referenced this issue Jul 26, 2021
@MaxGoryunov
#40: fixed PHPStan complaint about Generator usage
0af9f4b
MaxGoryunov added a commit that referenced this issue Jul 26, 2021
@MaxGoryunov
#40: added PHPStan ignore
c632d30
@0pdd 0pdd closed this as completed Jul 26, 2021
@0pdd
Copy link
Collaborator Author

0pdd commented Jul 26, 2021

The puzzle 8-efc308e6 has disappeared from the source code, that's why I closed this issue.

0pdd referenced this issue Jul 26, 2021
@MaxGoryunov
Merge pull request #47 from MaxGoryunov/feature/40
285c485 
Feature/40
@0pdd 0pdd mentioned this issue Jul 26, 2021
Closed
@0pdd
Copy link
Collaborator Author

0pdd commented Jul 26, 2021

@0pdd the puzzle #48 is still not solved.

@0pdd
Copy link
Collaborator Author

0pdd commented Jul 30, 2021

@0pdd the only puzzle #48 is solved here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MaxGoryunov MaxGoryunov

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@0pdd @MaxGoryunov