Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The.php:10-12: Classes Let and The do not have proper... #51

Closed
0pdd opened this issue Jul 26, 2021 · 3 comments
Closed

The.php:10-12: Classes Let and The do not have proper... #51

0pdd opened this issue Jul 26, 2021 · 3 comments
Assignees
@MaxGoryunov
Labels
enhancement New feature or request

Comments

@0pdd
Copy link
Collaborator

0pdd commented Jul 26, 2021

The puzzle 44-d8e690f3 from #44 has to be resolved:

saving-iterator/fakes/The.php

Lines 10 to 12 in 00d45bd

* @todo #44:20min Classes Let and The do not have proper type hints in
* constructor and methods. Workarounds with `@var` tags must be removed
* after that.

The puzzle was created by Max Goryunov on 26-Jul-21.

Estimate: 20 minutes, role: DEV.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.
0pdd referenced this issue Jul 26, 2021
@MaxGoryunov
Merge pull request #46 from MaxGoryunov/feature/44
00d45bd 
Feature/44
This was referenced Jul 26, 2021
Closed
Closed
Closed
@MaxGoryunov MaxGoryunov self-assigned this Jul 26, 2021
@MaxGoryunov MaxGoryunov added the enhancement New feature or request label Jul 27, 2021
MaxGoryunov added a commit that referenced this issue Jul 28, 2021
@MaxGoryunov
#51: added typehints
ffcadad
MaxGoryunov added a commit that referenced this issue Jul 28, 2021
@MaxGoryunov
#51: added common Envelope class
15fa2a5
@MaxGoryunov MaxGoryunov mentioned this issue Jul 29, 2021
Merged
MaxGoryunov added a commit that referenced this issue Jul 29, 2021
@MaxGoryunov
#51: removed @todo marker
a04bcc4
MaxGoryunov added a commit that referenced this issue Jul 29, 2021
@MaxGoryunov
#51: changed template x to X
bfc33e0
MaxGoryunov added a commit that referenced this issue Jul 30, 2021
@MaxGoryunov
#51: fixed PHPStan compaints
8b869eb
@0pdd
Copy link
Collaborator Author

0pdd commented Jul 30, 2021

The puzzle 44-d8e690f3 has disappeared from the source code, that's why I closed this issue.

@0pdd 0pdd closed this as completed Jul 30, 2021
0pdd referenced this issue Jul 30, 2021
@MaxGoryunov
Merge pull request #59 from MaxGoryunov/feature/51
54fa0bb 
Feature/51
@0pdd 0pdd mentioned this issue Jul 30, 2021
Closed
@0pdd
Copy link
Collaborator Author

0pdd commented Jul 30, 2021

@0pdd the puzzle #64 is still not solved.

@0pdd
Copy link
Collaborator Author

0pdd commented Aug 5, 2021

@0pdd the only puzzle #64 is solved here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MaxGoryunov MaxGoryunov

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@0pdd @MaxGoryunov