Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

php.yml:27-28: The minimum required MSI percentage should... #55

Closed
0pdd opened this issue Jul 27, 2021 · 1 comment
Closed

php.yml:27-28: The minimum required MSI percentage should... #55

0pdd opened this issue Jul 27, 2021 · 1 comment
Assignees
@MaxGoryunov
Labels
enhancement New feature or request

Comments

@0pdd
Copy link
Collaborator

0pdd commented Jul 27, 2021

The puzzle 45-d697e058 from #45 has to be resolved:

saving-iterator/.github/workflows/php.yml

Lines 27 to 28 in 2e0d58a

# @todo #45:30min The minimum required MSI percentage should be 80%, but actual
# is 70%.

The puzzle was created by Max Goryunov on 26-Jul-21.

Estimate: 30 minutes, role: DEV.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.
0pdd referenced this issue Jul 27, 2021
@MaxGoryunov
Merge pull request #53 from MaxGoryunov/feature/45
2e0d58a 
Feature/45
@0pdd 0pdd mentioned this issue Jul 27, 2021
Closed
@MaxGoryunov MaxGoryunov added the enhancement New feature or request label Jul 27, 2021
@MaxGoryunov MaxGoryunov self-assigned this Jul 28, 2021
MaxGoryunov added a commit that referenced this issue Jul 29, 2021
@MaxGoryunov
#55: raised min MSI
652c5d8
MaxGoryunov added a commit that referenced this issue Jul 29, 2021
@MaxGoryunov
#55: raised min MSI
96f6220
@MaxGoryunov MaxGoryunov mentioned this issue Jul 29, 2021
Merged
MaxGoryunov added a commit that referenced this issue Jul 29, 2021
@MaxGoryunov
#55: removed @todo marker
b7036b6
@0pdd
Copy link
Collaborator Author

0pdd commented Jul 31, 2021

The puzzle 45-d697e058 has disappeared from the source code, that's why I closed this issue.

@0pdd 0pdd closed this as completed Jul 31, 2021
0pdd referenced this issue Jul 31, 2021
@MaxGoryunov
Merge pull request #61 from MaxGoryunov/feature/55
2b75741 
Feature/55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MaxGoryunov MaxGoryunov

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@0pdd @MaxGoryunov