Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ArrayAddingIterator.php:38-39: Add a decorator for... #84

Closed
0pdd opened this issue Aug 23, 2021 · 1 comment
Closed

ArrayAddingIterator.php:38-39: Add a decorator for... #84

0pdd opened this issue Aug 23, 2021 · 1 comment
Assignees
@MaxGoryunov
Labels
bug Something isn't working

Comments

@0pdd
Copy link
Collaborator

0pdd commented Aug 23, 2021

The puzzle 66-0f62b41f from #66 has to be resolved:

saving-iterator/src/ArrayAddingIterator.php

Lines 38 to 39 in 9f78ea7

* @todo #66:20min Add a decorator for AddingIterator which does not
* allow to add values if source is not valid.

The puzzle was created by Max Goryunov on 22-Aug-21.

Estimate: 20 minutes, role: DEV.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.
0pdd referenced this issue Aug 23, 2021
@MaxGoryunov
Merge pull request #79 from MaxGoryunov/feature/66
9f78ea7 
Feature/66
@0pdd 0pdd mentioned this issue Aug 23, 2021
Closed
@MaxGoryunov MaxGoryunov self-assigned this Aug 23, 2021
@MaxGoryunov MaxGoryunov added the bug Something isn't working label Aug 23, 2021
MaxGoryunov added a commit that referenced this issue Aug 24, 2021
@MaxGoryunov
#84: added ValidAddingIterator
87966dd
MaxGoryunov added a commit that referenced this issue Aug 25, 2021
@MaxGoryunov
#84: added PHPStan hints
67c906a
MaxGoryunov added a commit that referenced this issue Aug 26, 2021
@MaxGoryunov
#84: removed @todo marker
3803879
@MaxGoryunov MaxGoryunov mentioned this issue Aug 28, 2021
Merged
MaxGoryunov added a commit that referenced this issue Aug 29, 2021
@MaxGoryunov
#84: fixed tests
ae8051a
MaxGoryunov added a commit that referenced this issue Aug 31, 2021
@MaxGoryunov
#84: fixed test annotations
46546f9
MaxGoryunov added a commit that referenced this issue Sep 8, 2021
@MaxGoryunov
#84: fixed coverage
291fea3
@0pdd 0pdd closed this as completed Sep 9, 2021
@0pdd
Copy link
Collaborator Author

0pdd commented Sep 9, 2021

The puzzle 66-0f62b41f has disappeared from the source code, that's why I closed this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MaxGoryunov MaxGoryunov

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@0pdd @MaxGoryunov