Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SavingIterator.php:52-53: There is a private function in... #94

Closed
0pdd opened this issue Aug 27, 2021 · 1 comment
Closed

SavingIterator.php:52-53: There is a private function in... #94

0pdd opened this issue Aug 27, 2021 · 1 comment
Assignees
@MaxGoryunov
Labels
bug Something isn't working

Comments

@0pdd
Copy link
Collaborator

0pdd commented Aug 27, 2021

The puzzle 85-d49ed4bf from #85 has to be resolved:

saving-iterator/src/SavingIterator.php

Lines 52 to 53 in e96d259

* @todo #85:40min There is a private function in this class. It should
* be removed without creating the code duplication problem again.

The puzzle was created by Max Goryunov on 25-Aug-21.

Estimate: 40 minutes, role: DEV.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.
@0pdd 0pdd added the bug Something isn't working label Aug 27, 2021
@MaxGoryunov MaxGoryunov self-assigned this Aug 28, 2021
MaxGoryunov added a commit that referenced this issue Sep 4, 2021
@MaxGoryunov
#94: added ContextVeil
c3385ca
MaxGoryunov added a commit that referenced this issue Sep 5, 2021
@MaxGoryunov
#94: added PHPStan hints
b26e599
@MaxGoryunov MaxGoryunov mentioned this issue Sep 17, 2021
Merged
MaxGoryunov added a commit that referenced this issue Sep 17, 2021
@MaxGoryunov
#94: Added context test
3bec8c4
MaxGoryunov added a commit that referenced this issue Sep 23, 2021
@MaxGoryunov
#94: fixed tests
1fb4a4f
MaxGoryunov added a commit that referenced this issue Sep 23, 2021
@MaxGoryunov
#94: removed private method; added ContextVeil to SavingIterator
9cc7031
MaxGoryunov added a commit that referenced this issue Sep 28, 2021
@MaxGoryunov
#94: fixed annotations in tests
7d8ecca
MaxGoryunov added a commit that referenced this issue Sep 28, 2021
@MaxGoryunov
#94: changed ContextVeil creation to fix Infection
19a3548
@0pdd
Copy link
Collaborator Author

0pdd commented Sep 28, 2021

The puzzle 85-d49ed4bf has disappeared from the source code, that's why I closed this issue.

@0pdd 0pdd closed this as completed Sep 28, 2021
This was referenced Sep 28, 2021
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MaxGoryunov MaxGoryunov

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@0pdd @MaxGoryunov