Feature/102 #107
Merged
Feature/102 #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #107 +/- ##
===========================================
Coverage 100.00% 100.00%
Complexity 34 34
===========================================
Files 8 8
Lines 72 72
===========================================
Hits 72 72
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
MaxGoryunov
commented
Aug 30, 2021
Comment on lines
-85
to
-87
| /** | ||
| * @todo #95:15min Reset behaviour for array is not covered. | ||
| */ |
Comment on lines
+102
to
+107
| public function testGivesSameResultsOverDifferentIterations(): void | ||
| { | ||
| $iterator = new ArrayAddingIterator([4, 3, 85, 48, 19, 53]); | ||
| $this->assertEquals( | ||
| iterator_to_array($iterator), | ||
| iterator_to_array($iterator) |
There was a problem hiding this comment.
Decided not to test this with TimesCalled to make it simpler.
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR solves #102 . Reset behaviour is now tested.