Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

155 #156

Merged
merged 3 commits into from Jan 25, 2022
Merged

155 #156

merged 3 commits into from Jan 25, 2022

Conversation

MaxGoryunov
Copy link
Owner

This PR solves #155 . Added infection check for Travis CI.

@MaxGoryunov MaxGoryunov self-assigned this Jan 23, 2022
@codecov
Copy link

codecov bot commented Jan 23, 2022

Codecov Report

Merging #156 (16b513b) into master (c908ff0) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##              master      #156   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
  Complexity        75        75           
===========================================
  Files             17        17           
  Lines            162       162           
===========================================
  Hits             162       162           
Flag Coverage Δ
tests 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c908ff0...16b513b. Read the comment docs.

Copy link
Owner Author

@MaxGoryunov MaxGoryunov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything is fine.

Comment on lines +9 to +10
# Infection analysis
- XDEBUG_MODE=coverage ./vendor/bin/infection --min-msi=90 --min-covered-msi=90 --threads=4 --configuration=./infection.json.dist
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Infection check.

@@ -12,7 +11,8 @@
"vimeo/psalm": "^4.8",
"phpmd/phpmd": "^2.10",
"friendsofphp/php-cs-fixer": "^3.0",
"rregeer/phpunit-coverage-check": "^0.3.1"
"rregeer/phpunit-coverage-check": "^0.3.1",
"infection/infection": "^0.23.0"
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Infection is now a dev dependency.

@sonarcloud
Copy link

sonarcloud bot commented Jan 24, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codeclimate
Copy link

codeclimate bot commented Jan 24, 2022

Code Climate has analyzed commit 16b513b and detected 0 issues on this pull request.

View more on Code Climate.

@MaxGoryunov MaxGoryunov linked an issue Jan 25, 2022 that may be closed by this pull request
@MaxGoryunov
Copy link
Owner Author

@rultor merge this please

@rultor
Copy link
Collaborator

rultor commented Jan 25, 2022

@rultor merge this please

@MaxGoryunov OK, I'll try to merge now. You can check the progress of the merge here

@rultor
Copy link
Collaborator

rultor commented Jan 25, 2022

@rultor merge this please

@MaxGoryunov Oops, I failed. You can see the full log here (spent 2min)

3997375cd555: Pull complete
149b8954e630: Pull complete
6fa6be2f92b2: Pull complete
dbe9d894be16: Pull complete
Digest: sha256:868fadc13837d7d798565ccb6f77a52c8fda62c6f818cc55f22033be01927067
Status: Downloaded newer image for php:8.0.8-zts-buster
+ docker ps --filter=status=exited
+ grep --quiet '\smaxgoryunov_saving-iterator_156\s*$'
+ ls -al .
total 712
drwx--x--x  3 rultor rultor   4096 Jan 25 14:24 .
drwxrwxrwt 12 root   root   684032 Jan 25 14:24 ..
-rw-rw-r--  1 rultor rultor    444 Jan 25 14:24 end.sh
-rwxrwxr-x  1 rultor rultor    363 Jan 25 14:24 entry.sh
-rw-rw-r--  1 rultor rultor      5 Jan 25 14:24 pid
drwxrwxr-x  8 rultor rultor   4096 Jan 25 14:24 repo
-rwxrwxr-x  1 rultor rultor   5937 Jan 25 14:24 run.sh
-rw-rw-r--  1 rultor rultor    596 Jan 25 14:24 script.sh
-rw-rw-r--  1 rultor rultor   6463 Jan 25 14:24 stdout
++ pwd
++ pwd
+ docker run -t --rm -v /tmp/rultor-D992:/main --env=head=git@github.com:MaxGoryunov/saving-iterator.git --env=pull_id=156 --env=fork=git@github.com:MaxGoryunov/saving-iterator.git --env=fork_branch=155 --env=head_branch=master --env=pull_title=155 --env=author=maxgoryunov '--env=scripts=( '\''export '\''\'\'''\''head=git@github.com:MaxGoryunov/saving-iterator.git'\''\'\'''\'''\'' '\'';'\'' '\''export '\''\'\'''\''pull_id=156'\''\'\'''\'''\'' '\'';'\'' '\''export '\''\'\'''\''fork=git@github.com:MaxGoryunov/saving-iterator.git'\''\'\'''\'''\'' '\'';'\'' '\''export '\''\'\'''\''fork_branch=155'\''\'\'''\'''\'' '\'';'\'' '\''export '\''\'\'''\''head_branch=master'\''\'\'''\'''\'' '\'';'\'' '\''export '\''\'\'''\''pull_title=155'\''\'\'''\'''\'' '\'';'\'' '\''export '\''\'\'''\''author=maxgoryunov'\''\'\'''\'''\'' '\'';'\'' '\''composer install'\'' '\'';'\'' '\''./vendor/bin/phpunit --bootstrap=vendor/autoload.php --coverage-text'\'' '\'';'\'' '\''XDEBUG_MODE=coverage ./vendor/bin/infection --min-msi=80 --min-covered-msi=80 --threads=4'\'' '\'';'\'' '\''./vendor/bin/phpstan analyse'\'' '\'';'\'' )' --hostname=docker --privileged --memory=6g --memory-swap=16g --oom-kill-disable --cidfile=/tmp/rultor-D992/cid -w=/main -v /var/run/docker.sock:/var/run/docker.sock --name=maxgoryunov_saving-iterator_156 php:8.0.8-zts-buster /main/entry.sh
+ set -e
+ set -o pipefail
+ shopt -s dotglob
+ useradd -m -G sudo r
+ usermod -s /bin/bash r
+ echo '%sudo ALL=(ALL) NOPASSWD:ALL'
+ cp -R /root/.bashrc /root/.profile /home/r
+ cp -R ./cid ./end.sh ./entry.sh ./pid ./repo ./run.sh ./script.sh ./stdout /home/r
+ rm -rf repo
+ chown -R r:r /home/r
+ chmod a+x /home/r/script.sh
+ su --login r --command /home/r/script.sh
mesg: cannot open /dev/pts/0: Permission denied
+ set -e
+ set -o pipefail
+ shopt -s expand_aliases
+ alias 'sudo=sudo -i'
+ export HOME=/home/r
+ HOME=/home/r
+ cd /home/r/repo
+ export head=git@github.com:MaxGoryunov/saving-iterator.git
+ head=git@github.com:MaxGoryunov/saving-iterator.git
+ export pull_id=156
+ pull_id=156
+ export fork=git@github.com:MaxGoryunov/saving-iterator.git
+ fork=git@github.com:MaxGoryunov/saving-iterator.git
+ export fork_branch=155
+ fork_branch=155
+ export head_branch=master
+ head_branch=master
+ export pull_title=155
+ pull_title=155
+ export author=maxgoryunov
+ author=maxgoryunov
+ composer install
/home/r/script.sh: line 9: composer: command not found
container 7cebc531152530fdffccf6afa38e182d02e634656e1f422156e999416bb7d709 is dead
Tue Jan 25 14:25:21 CET 2022

@MaxGoryunov MaxGoryunov merged commit f4bf78a into master Jan 25, 2022
@MaxGoryunov MaxGoryunov deleted the 155 branch January 25, 2022 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Travis does not support Infection tests
2 participants