Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

180 #181

Merged
merged 3 commits into from Jul 2, 2022
Merged

180 #181

merged 3 commits into from Jul 2, 2022

Conversation

MaxGoryunov
Copy link
Owner

This PR solves #180 . SavingIterator extends IteratorEnvelope, code is now more compact.

@MaxGoryunov MaxGoryunov self-assigned this Jun 26, 2022
@codeclimate
Copy link

codeclimate bot commented Jun 26, 2022

Code Climate has analyzed commit a59f236 and detected 0 issues on this pull request.

View more on Code Climate.

@sonarcloud
Copy link

sonarcloud bot commented Jun 30, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Jun 30, 2022

Codecov Report

Merging #181 (0e811ba) into master (ca75424) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##              master      #181   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
+ Complexity        72        67    -5     
===========================================
  Files             17        17           
  Lines            153       144    -9     
===========================================
- Hits             153       144    -9     
Flag Coverage Δ
tests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/IteratorEnvelope.php 100.00% <ø> (ø)
src/SavingIterator.php 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca75424...0e811ba. Read the comment docs.

@MaxGoryunov
Copy link
Owner Author

@rultor merge this PR please.

@rultor
Copy link
Collaborator

rultor commented Jul 2, 2022

@rultor merge this PR please.

@MaxGoryunov OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit 0e811ba into master Jul 2, 2022
@rultor
Copy link
Collaborator

rultor commented Jul 2, 2022

@rultor merge this PR please.

@MaxGoryunov Done! FYI, the full log is here (took me 2min)

@MaxGoryunov MaxGoryunov deleted the 180 branch July 6, 2022 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants