Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

183 #184

Merged
merged 1 commit into from Jul 14, 2022
Merged

183 #184

merged 1 commit into from Jul 14, 2022

Conversation

MaxGoryunov
Copy link
Owner

This PR solves #183 . ValidTernary cannot be made constant because it uses variables from outer scope.

@sonarcloud
Copy link

sonarcloud bot commented Jul 14, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@MaxGoryunov MaxGoryunov self-assigned this Jul 14, 2022
@codeclimate
Copy link

codeclimate bot commented Jul 14, 2022

Code Climate has analyzed commit 4333bdb and detected 0 issues on this pull request.

View more on Code Climate.

@codecov
Copy link

codecov bot commented Jul 14, 2022

Codecov Report

Merging #184 (4333bdb) into master (26d10c9) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##              master      #184   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
  Complexity        68        68           
===========================================
  Files             18        18           
  Lines            156       155    -1     
===========================================
- Hits             156       155    -1     
Flag Coverage Δ
tests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/SavingIterator.php 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26d10c9...4333bdb. Read the comment docs.

@MaxGoryunov
Copy link
Owner Author

@rultor merge PR please.

@rultor
Copy link
Collaborator

rultor commented Jul 14, 2022

@rultor merge PR please.

@MaxGoryunov OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit 4333bdb into master Jul 14, 2022
@rultor
Copy link
Collaborator

rultor commented Jul 14, 2022

@rultor merge PR please.

@MaxGoryunov Done! FYI, the full log is here (took me 2min)

@MaxGoryunov MaxGoryunov deleted the 183 branch July 20, 2022 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants