Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/69 #87

Merged
merged 4 commits into from Aug 25, 2021
Merged

Feature/69 #87

merged 4 commits into from Aug 25, 2021

Conversation

MaxGoryunov
Copy link
Owner

This PR solves #69 . Now codecov only accepts coverage at 100%.

@codecov-commenter
Copy link

codecov-commenter commented Aug 23, 2021

Codecov Report

Merging #87 (d1c023b) into master (6103447) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##              master       #87   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
  Complexity        30        30           
===========================================
  Files              7         7           
  Lines             64        64           
===========================================
  Hits              64        64           
Flag Coverage Δ
tests 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6103447...d1c023b. Read the comment docs.

Copy link
Owner Author

@MaxGoryunov MaxGoryunov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything is fine.

@@ -1,16 +1,13 @@
codecov:
require_ci_to_pass: yes
# @todo #52:15min add codecov strict analysis for 100% coverage.
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed @todo marker.

Comment on lines -8 to +10
target: auto
threshold: 10%
target: 100%
project:
default:
target: auto
threshold: 10%
target: 100%
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Elevated required coverage to 100%.

@sonarcloud
Copy link

sonarcloud bot commented Aug 25, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@MaxGoryunov MaxGoryunov merged commit ac139c4 into master Aug 25, 2021
@MaxGoryunov MaxGoryunov deleted the feature/69 branch August 25, 2021 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants