New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/69 #87
Feature/69 #87
Conversation
Codecov Report
@@ Coverage Diff @@
## master #87 +/- ##
===========================================
Coverage 100.00% 100.00%
Complexity 30 30
===========================================
Files 7 7
Lines 64 64
===========================================
Hits 64 64
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything is fine.
@@ -1,16 +1,13 @@ | |||
codecov: | |||
require_ci_to_pass: yes | |||
# @todo #52:15min add codecov strict analysis for 100% coverage. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed @todo marker.
target: auto | ||
threshold: 10% | ||
target: 100% | ||
project: | ||
default: | ||
target: auto | ||
threshold: 10% | ||
target: 100% |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Elevated required coverage to 100%.
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
This PR solves #69 . Now codecov only accepts coverage at 100%.