Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Caret symbol ( ^ ) no longer works in PowerShell Core #47

Closed
Snaptags opened this issue Nov 23, 2021 · 9 comments
Closed

Caret symbol ( ^ ) no longer works in PowerShell Core #47

Snaptags opened this issue Nov 23, 2021 · 9 comments

Comments

@Snaptags
Copy link

Snaptags commented Nov 23, 2021

Mod3 + t no longer prints a ^ in PowerShell Core (but works in any other application)

Last version where it did work was v0.5.2.

(PowerShell 7.2.0, Windows 10)

@MaxGyver83
Copy link
Owner

Thanks for your feedback. I'll check it.

@MaxGyver83
Copy link
Owner

I have installed PowerShell 7.2.0 and I can reproduce the issue. It looks like this issue was introduced by commit 51fdd3a which fixed #26 (Backtick and caret insert just a space (only in Neovim)).
When I just undo this change, the caret will be broken in Neovim again. This means, I'll have to investigate how to make the caret work both in in Neovim and PowerShell Core.

@Snaptags
Copy link
Author

Snaptags commented Dec 12, 2021

Other characters on Layer 3 seem to be affected, too:
… (Q)
ſ (ü)
̷ (*)

` (B)

And the entire number row ¹²³›‹ ¢¥‚‘’—

(But all of those are not really important in a shell, the missing ^ is bad because of HEAD^ vs HEAD~1 in git :-)

@MaxGyver83
Copy link
Owner

The characters that don't work are those sent as Unicode characters. The alternative is emulating the key press (combination) that emits the desired character usually. But that's only possible if that character is available in the system keyboard layout (QWERTZ). We can emit a caret and backtick by sending the corresponding dead keys followed by a space. But there is no workaround for …, ſ, ̷ and so on (except using an external tool like WinCompose but this didn't work either in a quick test).

I have added a new option called preferDeadKeyPlusSpace in commit bc1236e. This should make caret and backtick work in PowerShell Core 7.2. Would you mind testing it?

neo-llkh.zip

Just set preferDeadKeyPlusSpace=1 in your settings.ini or add it as command line parameter.

@Snaptags
Copy link
Author

Thanks, I can confirm the change (and enabling the new option) fixes dead keys in PowerShell. BUT it also breaks my "ä" key, it no longer prints "y" :(

@MaxGyver83
Copy link
Owner

Oh, that's bad! And strange. Thanks for testing. I'll check again.

@MaxGyver83
Copy link
Owner

You are right! The build I attached contained some uncommitted changes which I didn't want to include. (The "ä" is another shift key in that build.)

Could you try again with this version?
neo-llkh.zip

@Snaptags
Copy link
Author

That's much better, thanks :-)

@MaxGyver83
Copy link
Owner

Good to hear! I'll create a new release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants