Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

To create new operator functions #1

Open
hsph-kr opened this issue Jun 1, 2018 · 11 comments
Open

To create new operator functions #1

hsph-kr opened this issue Jun 1, 2018 · 11 comments

Comments

@hsph-kr
Copy link

hsph-kr commented Jun 1, 2018

I need to add some new operator functions. Is there a way to do it? Also the exponential function is not working and it stops the kernel.

image

@MaxHalford
Copy link
Owner

Hey,

Alas you can't add operators yourself. New operators have to be implemented in the core XGP library. What operators did you have in mind? Yeah the exponential function probably produces plus infinity values.

@hsph-kr
Copy link
Author

hsph-kr commented Jun 4, 2018

Max, Thanks for your response. I was looking for inverse and modulus function. One more clarification, the XGPClassifier uses sigmoid func to filter out probabilities and it seems the threshold value is ~0.6. Please correct me if I am wrong. I need this in a project. thanks!

@MaxHalford
Copy link
Owner

Hey,

I'll implement these functions soon!

What do you mean by the threshold value is ~0.6? Do you mean it's not predicting anything higher? If that's what you mean then it's probably just bad/good luck! I'll implement a method so that you can get the raw output and then apply the sigmoid transform yourself.

@hsph-kr
Copy link
Author

hsph-kr commented Jun 4, 2018

The classifier predicts 1 when the predict_proba values are >0.6. Hence the threshold value 0.6. I think the model.program_str_ expression when evaluated and transformed using sigmoid func gives predict_proba values. Please correct me if I am wrong.

@MaxHalford
Copy link
Owner

Well if you look here the threshold is at 0.5. The program_str_, when evaluated, gives the raw values so don't worry.

@hsph-kr
Copy link
Author

hsph-kr commented Jun 4, 2018

Oh. Ok. Thanks a lot for clarification.

@MaxHalford
Copy link
Owner

Hey, quick question: by modulus function do you mean the absolute value |x| or actually x % m?

@hsph-kr
Copy link
Author

hsph-kr commented Jun 5, 2018 via email

@MaxHalford
Copy link
Owner

Okay cheers, I'm doing it now.

@hsph-kr
Copy link
Author

hsph-kr commented Jun 7, 2018

Hey Max,
I asked you earlier about exponential operator and tried it on standardised data transformed by standard scalar() but still the kernel is crashing. Does the backend implementation of exp has issues?

@MaxHalford
Copy link
Owner

Hey,

I don't think it has. But it's pretty likely that it overflows because the exponent is too high.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants