-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #17 from Maxcutex/PA-16-create-skill-crud-api-and-…
…corresponding-tests [WIP] - Pa 16 create skill crud api and corresponding tests
- Loading branch information
Showing
12 changed files
with
647 additions
and
135 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,55 @@ | ||
from app.blueprints.base_blueprint import ( | ||
Blueprint, | ||
BaseBlueprint, | ||
request, | ||
Security, | ||
Auth, | ||
) | ||
from app.controllers.skill_controller import SkillController | ||
|
||
url_prefix = "{}/skills".format(BaseBlueprint.base_url_prefix) | ||
skill_blueprint = Blueprint("skill", __name__, url_prefix=url_prefix) | ||
skill_controller = SkillController(request) | ||
|
||
|
||
@skill_blueprint.route("/", methods=["GET"]) | ||
@Auth.has_permission(["view_skill"]) | ||
def list_skills(): | ||
return skill_controller.list_skills() | ||
|
||
|
||
@skill_blueprint.route("/<int:id>/", methods=["GET"]) | ||
@Auth.has_permission(["view_skill"]) | ||
def get_skill(skill_id): | ||
return skill_controller.get_skill(skill_id) | ||
|
||
|
||
@skill_blueprint.route("/", methods=["POST"]) | ||
@Security.validator( | ||
[ | ||
"name|required:string", | ||
"skill_category_id|required:int", | ||
] | ||
) | ||
@Auth.has_permission(["create_skill"]) | ||
def create_skill(): | ||
return skill_controller.create_skill() | ||
|
||
|
||
@skill_blueprint.route("/<int:skill_id>", methods=["PUT", "PATCH"]) | ||
@Security.validator( | ||
[ | ||
"skill_id|required:int", | ||
"name|required:string", | ||
"skill_category_id|required:int", | ||
] | ||
) | ||
@Auth.has_permission(["update_skill"]) | ||
def update_skill(skill_id): | ||
return skill_controller.update_skill(skill_id) | ||
|
||
|
||
@skill_blueprint.route("/<int:skill_id>", methods=["DELETE"]) | ||
@Auth.has_permission(["delete_skill"]) | ||
def delete_skill(skill_id): | ||
return skill_controller.delete_skill(skill_id) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,84 @@ | ||
from app.controllers.base_controller import BaseController | ||
from app.repositories.skill_repo import SkillRepo | ||
|
||
|
||
class SkillController(BaseController): | ||
def __init__(self, request): | ||
BaseController.__init__(self, request) | ||
self.skill_repo = SkillRepo() | ||
|
||
def list_skills(self): | ||
skills = self.skill_repo.get_unpaginated() | ||
skill_list = [skill.serialize() for skill in skills.items] | ||
return self.handle_response( | ||
"OK", | ||
payload={ | ||
"skills": skill_list, | ||
}, | ||
) | ||
|
||
def get_skill(self, skill_id): | ||
skill = self.skill_repo.find_first(id=skill_id) | ||
if skill: | ||
return self.handle_response("OK", payload={"skill": skill.serialize()}) | ||
return self.handle_response("Invalid or Missing skill_id", status_code=400) | ||
|
||
def create_skill(self): | ||
name, skill_category_id = self.request_params("name", "skill_category_id") | ||
skill = self.skill_repo.find_first( | ||
name=name, skill_category_id=skill_category_id | ||
) | ||
|
||
if skill: | ||
print("testing ....") | ||
return self.handle_response( | ||
f"Skill name {skill.name} with category name {skill.skill_category.name} already exists", | ||
status_code=400, | ||
) | ||
skill = self.skill_repo.new_skill( | ||
name=name, skill_category_id=skill_category_id | ||
) | ||
|
||
return self.handle_response( | ||
"OK", payload={"skill": skill.serialize()}, status_code=201 | ||
) | ||
|
||
def update_skill(self, update_id): | ||
skill_id, name, skill_category_id = self.request_params( | ||
"skill_id", "name", "skill_category_id" | ||
) | ||
skill = self.skill_repo.find_first( | ||
name=name, skill_category_id=skill_category_id | ||
) | ||
|
||
skill_other = self.skill_repo.get(name=name) | ||
|
||
if skill_id != update_id: | ||
return self.handle_response( | ||
"Invalid or incorrect skill_id provided", status_code=400 | ||
) | ||
|
||
if skill: | ||
if skill.id == skill_other.id: | ||
skill = self.skill_repo.update( | ||
skill, **dict(name=name, skill_category_id=skill_category_id) | ||
) | ||
return self.handle_response( | ||
"OK", payload={"skill": skill.serialize()}, status_code=200 | ||
) | ||
else: | ||
return self.handle_response( | ||
f"Skill name '{name}' with category name {skill_other.skill_category.name} already exists", | ||
status_code=400, | ||
) | ||
return self.handle_response("Skill Not Found", status_code=404) | ||
|
||
def delete_skill(self, skill_id): | ||
skill = self.skill_repo.get(skill_id) | ||
update_dict = {"is_deleted": True} | ||
if skill: | ||
self.skill_repo.update(**update_dict) | ||
return self.handle_response("skill deleted", payload={"status": "success"}) | ||
return self.handle_response( | ||
"Invalid or incorrect skill_id provided", status_code=404 | ||
) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
import factory | ||
from app.utils import db | ||
from app.models import Skill | ||
from faker import Faker | ||
|
||
|
||
class SkillFactory(factory.alchemy.SQLAlchemyModelFactory): | ||
|
||
class Meta: | ||
model = Skill | ||
sqlalchemy_session = db.session | ||
|
||
id = factory.Sequence(lambda n: n) | ||
name = factory.Faker("city") | ||
skill_category_id = factory.Sequence(lambda n: n) | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
from tests.base_test_case import BaseTestCase | ||
|
||
class TestSkillEndpoints(BaseTestCase): | ||
|
||
def setUp(self): | ||
self.BaseSetUp() | ||
|
||
|
||
def tearDown(self): | ||
self.BaseTearDown() | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.