fix failing tests

Maxcutex · Feb 3, 2021 · de1e1a0 · de1e1a0
1 parent f7f765c
commit de1e1a0
Show file tree

Hide file tree

Showing 5 changed files with 15 additions and 3 deletions.
diff --git a/app/controllers/user_controller.py b/app/controllers/user_controller.py
@@ -213,7 +213,15 @@ def create_user(self):
                 f"User with email '{email}' already exists", status_code=400
             )
         try:
-            user = self.user_repo.new_user(*user_info).serialize()
+            user = self.user_repo.new_user(
+                first_name,
+                last_name,
+                email,
+                gender,
+                date_of_birth,
+                location_id,
+                password,
+            ).serialize()
             del user["password"]
             user_role = self.user_role_repo.new_user_role(
                 role_id=role_id, user_id=user["id"]

diff --git a/app/repositories/user_repo.py b/app/repositories/user_repo.py
@@ -21,7 +21,7 @@ def new_user(
         date_of_birth,
         location_id,
         password,
-        employment_date,
+        employment_date=datetime.datetime.now().strftime("%Y-%m-%d"),
     ):
         """
         function for creating a new user

diff --git a/factories/user_factory.py b/factories/user_factory.py
@@ -24,6 +24,7 @@ class Meta:
     image_url = factory.Faker("url")
     gender = "male"
     date_of_birth = fake.date_between()
+    employment_date = fake.date_between()
     is_active = True
     is_deleted = False
 
@@ -42,5 +43,6 @@ class Meta:
     image_url = factory.Faker("url")
     gender = "male"
     date_of_birth = fake.date_between()
+    employment_date = fake.date_between()
     is_active = True
     is_deleted = False
diff --git a/tests/integration/endpoints/test_user_endpoints.py b/tests/integration/endpoints/test_user_endpoints.py
@@ -320,8 +320,10 @@ def test_create_user_endpoint_succeeds(self):
             role_id=role.id,
             gender=user.gender,
             date_of_birth=str(user.date_of_birth),
+            employment_date=str(user.employment_date),
             password=user.password,
             email=user.email,
+            location_id=user.location_id,
         )
 
         response = self.client().post(
@@ -331,6 +333,7 @@ def test_create_user_endpoint_succeeds(self):
         )
 
         response_json = self.decode_from_json_string(response.data.decode("utf-8"))
+        print(response_json)
         self.assertEqual(response.status_code, 201)
         self.assertEqual(response_json["msg"], "OK")
         self.assertEqual(

diff --git a/tests/unit/repositories/test_user_repo.py b/tests/unit/repositories/test_user_repo.py
@@ -26,7 +26,6 @@ def test_new_user_method_returns_new_user_object(self):
             user.first_name,
             user.last_name,
             user.email,
-            role.id,
             "male",
             datetime.datetime.now().strftime("%Y-%m-%d"),
             1,