-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prototype build artifact #98
Conversation
My problem with leaving JSON in the |
…generator into build-artifact * 'master' of github.com:Maxim-Mazurok/google-api-typings-generator: #96 (comment)
Whould be great to have it finalized, because because my approach of |
Sorry, I'll try to circle back to this later today or tomorrow! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Maxim-Mazurok, I think I came up with a solid solution that hopefully works for you as well!
This still uploads the full types
artifact on success, but to address your lint failure scenario, I ended up leveraging a workflow command to upload the specific types associated with the service that failed.
if: failure() | ||
with: | ||
name: ${{ env.FAILED_TYPE }} | ||
path: types/${{ env.FAILED_TYPE }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Learning more about expression syntax, there is probably an option to minimize some of this duplication, consolidating workflows in favor of conditional logic, but this is duplicated for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nicely done 👍 Liked the `::set-env`` approach, thank you!
And yes, it would be nice to figure out how to eliminate duplication from the workflows in the future, create a new issue for this, please.
This doesn't buy us much but also doesn't hurt in my opinion. I mostly wanted to prototype artifact functionality mentioned in #96 (comment). If we like this approach, we might consider uploading an artifact when linting fails to minimize some of the verbose stdout.
Specifically, this:
GAPI_MAX_PARALLEL: 3
inbuild / generate
jobbuild / generate
before deploying**I tested this on a forked repository; here's what it looks like: