New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad scrolling with pager in git bash #1355

Closed
Will-W opened this Issue Dec 8, 2017 · 6 comments

Comments

Projects
2 participants
@Will-W

Will-W commented Dec 8, 2017

Versions

ConEmu build: 171205 x64
OS version: Windows 8 x64
Shell: git-bash that came with git version 2.14.2.windows.3

Problem description

When I use a git command that invokes the pager (e.g. git log), I get bad behaviour with scrolling. When I'm navigating down the pager output it's fine, but when I press 'Up' or 'PageUp' the console scrollbar goes back to the top which means when I quit I have a load of nonsense from my log output all over subsequent lines of terminal.

If I use less directly to display something, there are no issues. The console scroll bar disappears completely while less is active and everything is fine when I quit less.

Steps to reproduce

[The issue is more clearly visible if you disable autohide on the scrollbar]

  1. Run 'git log' on a repo with more than a screen of log output
  2. Press the down arrow or page down until you are a few screens of info down
  3. Press the up arrow once
  4. Press q to leave

Actual results

Scrollbar jumps to top on step(3)
On quitting, the prompt is on screen at the top of the scroll range of the console rather than the bottom, and there is junk log output on the screen. Hitting enter on the console puts it a line down, but in the midst of the junk.

This is the result: gitpager_issue

Expected results

Same behaviour as using less: no scrollbar while the pager is active, no effect on console scroll when navigating up and down. On quitting, prompt is still at the bottom of the console scrollback, and none of the pager output is visible.

@Maximus5

This comment has been minimized.

Show comment
Hide comment
@Maximus5

Maximus5 Dec 8, 2017

Owner

I do not see "Terminal modes" column in the status bar.
How do you run git bash?

Owner

Maximus5 commented Dec 8, 2017

I do not see "Terminal modes" column in the status bar.
How do you run git bash?

@Will-W

This comment has been minimized.

Show comment
Hide comment
@Will-W

Will-W Dec 8, 2017

The command is:
set "PATH=%ConEmuDir%\..\Git\usr\bin;%PATH%" & "%ConEmuDir%\..\Git\git-cmd.exe" --no-cd --command=%ConEmuBaseDirShort%\conemu-msys2-64.exe /usr/bin/bash.exe -l -i -new_console:p

I assume that must have been set up automatically?

Will-W commented Dec 8, 2017

The command is:
set "PATH=%ConEmuDir%\..\Git\usr\bin;%PATH%" & "%ConEmuDir%\..\Git\git-cmd.exe" --no-cd --command=%ConEmuBaseDirShort%\conemu-msys2-64.exe /usr/bin/bash.exe -l -i -new_console:p

I assume that must have been set up automatically?

@Maximus5

This comment has been minimized.

Show comment
Hide comment
@Maximus5

Maximus5 Dec 8, 2017

Owner

If you run git-bash.exe standalone (mintty, no ConEmu) you'll see same behavior - scrollbar is not disabled.

Owner

Maximus5 commented Dec 8, 2017

If you run git-bash.exe standalone (mintty, no ConEmu) you'll see same behavior - scrollbar is not disabled.

@Will-W

This comment has been minimized.

Show comment
Hide comment
@Will-W

Will-W Dec 8, 2017

True, there is a difference in behaviour in mintty between less and the git pager. Mintty doesn't jump to the top when you press 'up' in the git log output though. It's that jump in ConEmu that's the actual problem.

Will-W commented Dec 8, 2017

True, there is a difference in behaviour in mintty between less and the git pager. Mintty doesn't jump to the top when you press 'up' in the git log output though. It's that jump in ConEmu that's the actual problem.

@Maximus5 Maximus5 added this to To Do in ConEmu via automation Jan 10, 2018

@Maximus5 Maximus5 added the ansi label Jan 10, 2018

@Maximus5 Maximus5 moved this from To Do to In progress in ConEmu Jan 11, 2018

@Maximus5

This comment has been minimized.

Show comment
Hide comment

@Maximus5 Maximus5 moved this from In progress to Ready for Testing in ConEmu Jan 15, 2018

@Will-W

This comment has been minimized.

Show comment
Hide comment
@Will-W

Will-W Jan 15, 2018

I can confirm that this issue appears to be fixed in 'Build 180114 (alpha)'.

Thank you!

Will-W commented Jan 15, 2018

I can confirm that this issue appears to be fixed in 'Build 180114 (alpha)'.

Thank you!

@Maximus5 Maximus5 closed this Jan 15, 2018

ConEmu automation moved this from Ready for Testing to Done Jan 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment