Fix: Replace Deprecated Tolerance (#118)

* fix tolerance to toleranceFor * update version and changelog
MayLau-CbL · Jun 17, 2023 · b07e8a3 · b07e8a3
1 parent b30b9c9
commit b07e8a3
Show file tree

Hide file tree

Showing 4 changed files with 20 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,6 @@
+## [4.3.1] - 20230617
+* Fix: replace deprecated tolerance with toleranceFor
+
 ## [4.3.0+1] - 20230617
 * Fix: web and android example
 

diff --git a/example/pubspec.lock b/example/pubspec.lock
@@ -44,7 +44,7 @@ packages:
       path: ".."
       relative: true
     source: path
-    version: "4.3.0"
+    version: "4.3.1"
   http:
     dependency: "direct main"
     description:

diff --git a/lib/refresh/pull_to_refresh/src/internals/refresh_physics.dart b/lib/refresh/pull_to_refresh/src/internals/refresh_physics.dart
@@ -281,6 +281,9 @@ class RefreshPhysics extends ScrollPhysics {
     if ((position.pixels > 0 &&
             controller!.headerMode!.value == RefreshStatus.twoLeveling) ||
         position.outOfRange) {
+      BuildContext? scrollViewContext =
+          controller!.position?.context.storageContext;
+
       return BouncingScrollSimulation(
         spring: springDescription ?? spring,
         position: position.pixels,
@@ -292,7 +295,18 @@ class RefreshPhysics extends ScrollPhysics {
             controller!.headerMode!.value == RefreshStatus.twoLeveling
                 ? 0.0
                 : position.maxScrollExtent,
-        tolerance: tolerance,
+        tolerance: toleranceFor(
+          FixedScrollMetrics(
+            minScrollExtent: null,
+            maxScrollExtent: null,
+            pixels: null,
+            viewportDimension: null,
+            axisDirection: AxisDirection.down,
+            devicePixelRatio: scrollViewContext == null
+                ? 1.0
+                : View.of(scrollViewContext).devicePixelRatio,
+          ),
+        ),
       );
     }
     return super.createBallisticSimulation(position, velocity);

diff --git a/pubspec.yaml b/pubspec.yaml
@@ -1,6 +1,6 @@
 name: horizontal_data_table
 description: A horizontal data table with a fixed column on left handside.
-version: 4.3.0+1
+version: 4.3.1
 author: May Lau<may.lau.dev@gmail.com>
 homepage: https://github.com/MayLau-CbL/flutter_horizontal_data_table