let the right and left list sync again #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MayLau-CbL
reviewed
Jun 6, 2021
| switch (_refreshController?.headerStatus) { | ||
| case RefreshStatus.canRefresh: | ||
| { | ||
| //log(_scrollingController.offset.toString() + ", " + _refreshIndicatorHeight.toString()); |
There was a problem hiding this comment.
Thanks @yingshaoxo ! I have tested web, android and ios which are all good. would you mind removing the log comment and the import 'dart:developer'; line. then I will accept the PR and later release a new version.😉
There was a problem hiding this comment.
Hi, MyaLau-CbL. I just did what you asked. It's my pleasure to make a contribution.
MayLau-CbL
approved these changes
Jun 6, 2021
|
Thank you again for the contribution. I will make a release for this tonight and will update you the status. |
|
This PR is available on the v3.4.1 on pub.dev. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solution works for all kinds of
HeadersResolves: #49