Merge pull request #57 from Mazars-Tech/fix-os-lowercase

fix: fix OS format for obsolete OS
Mazars-Tech · Oct 26, 2023 · c5fc973 · c5fc973
2 parents 50e152d + 7f70296
commit c5fc973
Showing 1 changed file with 10 additions and 7 deletions.
diff --git a/ad_miner/sources/modules/computers.py b/ad_miner/sources/modules/computers.py
@@ -562,16 +562,19 @@ def manageComputersOs(computer_list):
 
         for line in computer_list:
             os = line["os"]
-            if "Windows" in line["os"] or "windows" in line["os"]:
+            if "windows" in os.lower():
+                os = os.lower()
                 os = os.replace("\xa0", " ")
                 os = os.replace("®", "")
-                os = os.replace(" Server", "")
-                os = os.replace(" Storage", "")
-                os = os.replace(" 2008 R2", " 2008R2")
-                os = os.replace(" 2012 R2", " 2012R2")
-                ver = re.match(r"^Windows ([.a-zA-Z0-9]+)\s", os, re.M | re.I)
+                os = os.replace(" server", "")
+                os = os.replace(" storage", "")
+                os = os.replace(" 2008 r2", " 2008R2")
+                os = os.replace(" 2012 r2", " 2012R2")
+                ver = re.match(r"^windows ([.a-zA-Z0-9]+)\s", os, re.M | re.I)
                 if ver:
-                    os = "Windows " + ver.group(1)
+                    os = "Windows " + ver.group(1).upper()
+                else:
+                    os = os.replace("windows", "Windows")
             else:
                 os = os[0:16] + "[..]"