Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: small rework for GPO #54

Merged
merged 3 commits into from
Oct 25, 2023
Merged

feat: small rework for GPO #54

merged 3 commits into from
Oct 25, 2023

Conversation

Tanguy-Boisset
Copy link
Collaborator

This PR reworks the GPO control by adding a new column that shows the target interest.
The value follows this logic :

  • 0 star : no object impacted
  • 1 star : at least one object impacted
  • 2 stars : at least one admin account impacted
  • 3 stars : full domain or at least one domain admin impacted

@Tanguy-Boisset
Copy link
Collaborator Author

image

@k4amos
Copy link
Collaborator

k4amos commented Oct 25, 2023

it's more a big PR 😄 than a small rework...
it works well 👍

@k4amos k4amos merged commit 50e152d into dev Oct 25, 2023
@Tanguy-Boisset Tanguy-Boisset deleted the rework-gpo branch October 25, 2023 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmbesnard jmbesnard jmbesnard approved these changes

@k4amos k4amos k4amos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Tanguy-Boisset @k4amos @jmbesnard