Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Chinese Guomi SM2 crypt #1620

Closed
wants to merge 14 commits into from
Closed

Support Chinese Guomi SM2 crypt #1620

wants to merge 14 commits into from

Conversation

youngbug
Copy link

@youngbug youngbug commented May 9, 2018

Support Chinese Guomi SM2 Digital Signature Algorithm,SM2 256bit curve.

@RonEld
Copy link
Contributor

RonEld commented May 9, 2018

@youngbug Thank you for your contribution!
Please rebase and resolve the confllct in ecp.h
In addition, it would be appreciated if you would add tests and a ChangLog entry to your enhancment.

In addition, unfortunately our policy is to not accept contributions, without a Contributor’s Licence Agreement (CLA) signed or authorised by yourself or your employer.
If this is a personal contribution, the easiest way to do this is if you create an mbed account and accept this click through agreement. Alternatively, you can find a slightly different agreement to sign here, which can be signed and returned to us, and is applicable if you don't want to create an mbed account or alternatively if this is a corporate contribution.
Thanks for your understanding and again, thanks for the contribution!

@youngbug
Copy link
Author

CLA has just been submitted through Email

yhio
yhio reviewed May 14, 2018
View reviewed changes
library/ecp_curves.c Outdated
@@ -752,6 +793,12 @@ int mbedtls_ecp_group_load( mbedtls_ecp_group *grp, mbedtls_ecp_group_id id )

switch( id )
{
#if defined(MBEDTLS_ECP_DP_CURVE_SM2_256_ENABLED)
case MBEDTLS_ECP_DP_SM2256:
grp->modp = NULL;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I test sm2 in stm32, it works well, but it too slow, can you implement a fast mod function? and thank you!

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@youngbug

@simonbutcher simonbutcher added the component-crypto Crypto primitives and low-level interfaces label May 18, 2018
@youngbug
Copy link
Author

I cannot link to the url: https://jenkins-internal.mbed.com/job/mbedtls-pr-multibranch/job/PR-1620/2/display/redirect
Does the server get some error?

@jforissier jforissier mentioned this pull request Feb 1, 2021
Merged
@chris-jones-arm chris-jones-arm mentioned this pull request Feb 1, 2021
Draft
@youngbug youngbug closed this Aug 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yhio yhio yhio left review comments

Assignees
No one assigned
Labels
component-crypto Crypto primitives and low-level interfaces enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@youngbug @RonEld @yhio @simonbutcher