Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport 2.7: x509.c: Remove unused includes #1827

Merged
merged 2 commits into from Jul 11, 2018
Merged

Backport 2.7: x509.c: Remove unused includes #1827

merged 2 commits into from Jul 11, 2018

Conversation

simonbutcher
Copy link
Contributor

Description

This is a backport of #1563, which is part of a fix for #992.

The PR removes unused headers included in x509.c, guarded by MBEDTLS_FS_IO, which doesn't appear anywhere else in the file.

Status

READY

Todos

  • Tests
  • Documentation
  • Changelog updated
  • Backported

mrpippy and others added 2 commits July 2, 2018 12:13
@mrpippy @simonbutcher
x509.c: Remove unused includes
b322333 
Remove unused includes guarded by MBEDTLS_FS_IO, which doesn't appear
anywhere else in the file.
@simonbutcher
Add ChangeLog entry for Mbed-TLS#992 fix
318cd2c
@simonbutcher simonbutcher added bug CLA valid needs-review Every commit must be reviewed by at least two team members, component-x509 labels Jul 2, 2018
RonEld
RonEld approved these changes Jul 2, 2018
View reviewed changes
Copy link
Contributor

@RonEld RonEld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good. The only thing that puzzles me is why other entries in the ChangeLog here don't exist in the changeLog of the original PR (as unchanged lines)?

mazimkhan
mazimkhan approved these changes Jul 2, 2018
View reviewed changes
Copy link

@mazimkhan mazimkhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@simonbutcher simonbutcher mentioned this pull request Jul 2, 2018
Merged
4 tasks
@simonbutcher simonbutcher added approved Design and code approved - may be waiting for CI or backports and removed needs-review Every commit must be reviewed by at least two team members, labels Jul 2, 2018
@simonbutcher simonbutcher merged commit 318cd2c into Mbed-TLS:mbedtls-2.7 Jul 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mazimkhan mazimkhan mazimkhan approved these changes

@RonEld RonEld RonEld approved these changes

Assignees
No one assigned
Labels
approved Design and code approved - may be waiting for CI or backports bug component-x509
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@simonbutcher @mazimkhan @RonEld @mrpippy