Fix build failure on gcc-11 #3848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rodrigo-dc
force-pushed
the
development
branch
from
660dd9f
to
4a884a3
Compare
yanesca
added
Community
needs-review
yanesca
added this to To Do
in OBSOLETE - PLEASE SEE https://github.com/orgs/Mbed-TLS/projects/2
via automation
gilles-peskine-arm
requested changes
Nov 9, 2020
There was a problem hiding this comment.
Please add a changelog entry file in ChangeLog.d indicating that this fixes the build with GCC 11 and referencing #3782.
OBSOLETE - PLEASE SEE https://github.com/orgs/Mbed-TLS/projects/2
automation
moved this from To Do
to In Progress
Nov 9, 2020
gilles-peskine-arm
added
component-platform
rodrigo-dc
force-pushed
the
development
branch
from
4a884a3
to
d84ebf4
Compare
gilles-peskine-arm
requested changes
Nov 19, 2020
gilles-peskine-arm
added
needs-backports
|
LTS branches should work under newer compilers too, so once we agree on the approach, this will need backports to |
rodrigo-dc
force-pushed
the
development
branch
from
d5dd793
to
72783c5
Compare
Function prototypes changed to use array parameters instead of pointers. Signed-off-by: Rodrigo Dias Correa <rodrigo@correas.us>
In GCC 11, parameters declared as arrays in function prototypes cannot be declared as pointers in the function definition. The same is true for the other way around. The definition of `mbedtls_aes_cmac_prf_128` was changed to match its public prototype in `cmac.h`. The type `output` was `unsigned char *`, now is `unsigned char [16]`. In `ssl_tls.c`, all the `ssl_calc_verify_*` variants now use pointers for the output `hash` parameter. The array parameters were removed because those functions must be compatible with the function pointer `calc_verify` (defined in `ssl_internal.h`). Signed-off-by: Rodrigo Dias Correa <rodrigo@correas.us>
GCC 11 generated the warnings because the parameter `ret_buf` was declared as `const char[10]`, but some of the arguments provided in `run_test_snprintf` are shorter literals, like "". Now the type of `ret_buf` is `const char *`. Both implementations of `test_snprintf` were fixed. Signed-off-by: Rodrigo Dias Correa <rodrigo@correas.us>
GCC 11 generated a warning because `padbuf` was too small to be used as an argument for `mbedtls_sha512_finish_ret`. The `output` parameter of `mbedtls_sha512_finish_ret` has the type `unsigned char[64]`, but `padbuf` was only 48 bytes long. Even though `ssl_calc_finished_tls_sha384` uses only 48 bytes for the hash output, the size of `padbuf` was increased to 64 bytes. Signed-off-by: Rodrigo Dias Correa <rodrigo@correas.us>
Signed-off-by: Rodrigo Dias Correa <rodrigo@correas.us>
This commit fixes the same warning fixed by baeedbf, but without wasting RAM. By casting `mbedtls_sha512_finish_ret()`, `padbuf` could be kept 48 bytes long without triggering any warnings. Signed-off-by: Rodrigo Dias Correa <rodrigo@correas.us>
rodrigo-dc
force-pushed
the
development
branch
from
72783c5
to
d596ca8
Compare
`finish_sha384_t` was made more generic by using `unsigned char*` instead of `unsigned char[48]` as the second parameter. This change tries to make the function casting more robust against future improvements of gcc analysis. Signed-off-by: Rodrigo Dias Correa <rodrigo@correas.us>
gilles-peskine-arm
approved these changes
Nov 25, 2020
gilles-peskine-arm
moved this from In Progress
to Has Approval
in OBSOLETE - PLEASE SEE https://github.com/orgs/Mbed-TLS/projects/2
chris-jones-arm
approved these changes
Nov 26, 2020
chris-jones-arm
removed
needs-review
This was referenced Nov 28, 2020
gilles-peskine-arm
added
approved
OBSOLETE - PLEASE SEE https://github.com/orgs/Mbed-TLS/projects/2
automation
moved this from Has Approval
to Done
Dec 1, 2020
bensze01
removed this from Done
in OBSOLETE - PLEASE SEE https://github.com/orgs/Mbed-TLS/projects/2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Function prototypes changed to use array parameters instead of
pointers.
Signed-off-by: Rodrigo Dias Corrêa rodrigo@correas.us
Description
Fixes #3782
Status
READY
Requires Backporting
I don't know.
Migrations
NO