Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated error codes. #4339

Merged
merged 17 commits into from
Apr 22, 2021
Merged

Remove deprecated error codes. #4339

merged 17 commits into from
Apr 22, 2021

Conversation

TRodziewicz
Copy link
Contributor

@TRodziewicz TRodziewicz commented Apr 12, 2021 •
edited

Signed-off-by: TRodziewicz tomasz.rodziewicz@mobica.com

Description

Remove deprecated error codes, which can be found using `git grep -i 'MBEDTLS_ERR.*deprecated'.

Fixes: #4283

Status

IN DEVELOPMENT

Requires Backporting

NO

Todos

  • Tests
  • Documentation
  • Changelog updated

@tomasz-rodziewicz-mobica
Remove deprecated error codes. Some still remain - question asked in …
dd82502 
…issue comment

Signed-off-by: TRodziewicz <tomasz.rodziewicz@mobica.com>
@TRodziewicz TRodziewicz added question help-wanted This issue is not being actively worked on, but PRs welcome. needs-work needs-review Every commit must be reviewed by at least two team members, needs-ci Needs to pass CI tests needs-reviewer This PR needs someone to pick it up for review size-s Estimated task size: small (~2d) labels Apr 12, 2021
@TRodziewicz TRodziewicz self-assigned this Apr 12, 2021
@TRodziewicz
Copy link
Contributor Author

Question about this task has been asked in the originating issue: #4283 (comment)

TRodziewicz and others added 2 commits April 12, 2021 23:39
@TRodziewicz
Update md.h
c258a0f
@tomasz-rodziewicz-mobica
Correction in the TODO issue number
d11ddc5 
Signed-off-by: TRodziewicz <tomasz.rodziewicz@mobica.com>
@tomasz-rodziewicz-mobica
Merge branch 'remove_depr_error_codes' of https://github.com/TRodziew…
bca65e4 
…icz/mbedtls into remove_depr_error_codes

Signed-off-by: TRodziewicz <tomasz.rodziewicz@mobica.com>
@TRodziewicz TRodziewicz removed help-wanted This issue is not being actively worked on, but PRs welcome. needs-review Every commit must be reviewed by at least two team members, needs-reviewer This PR needs someone to pick it up for review question labels Apr 12, 2021
@tomasz-rodziewicz-mobica
The still used deprecated error codes replaced with _PLATFORM_ ones
b579ccd 
Signed-off-by: TRodziewicz <tomasz.rodziewicz@mobica.com>
@tomasz-rodziewicz-mobica
error.c re-generated.
e148b68 
Signed-off-by: TRodziewicz <tomasz.rodziewicz@mobica.com>
@TRodziewicz TRodziewicz changed the title Remove deprecated error codes. Some still remain - question asked in … Remove deprecated error codes. Apr 13, 2021
@TRodziewicz TRodziewicz removed needs-ci Needs to pass CI tests needs-work labels Apr 13, 2021
@tomasz-rodziewicz-mobica
Changelog added
53423c0 
Signed-off-by: TRodziewicz <tomasz.rodziewicz@mobica.com>
@TRodziewicz TRodziewicz added needs-review Every commit must be reviewed by at least two team members, needs-reviewer This PR needs someone to pick it up for review labels Apr 13, 2021
@tomasz-rodziewicz-mobica
error.c re-generated once more
e022938 
Signed-off-by: TRodziewicz <tomasz.rodziewicz@mobica.com>
@tomasz-rodziewicz-mobica
revert the error.h file include in psa_util.c
3408d60 
Signed-off-by: TRodziewicz <tomasz.rodziewicz@mobica.com>
@mstarzyk-mobica mstarzyk-mobica self-requested a review April 21, 2021 13:14
mstarzyk-mobica
mstarzyk-mobica suggested changes Apr 21, 2021
View reviewed changes
ChangeLog.d/issue4283.txt Outdated
@@ -0,0 +1,2 @@
Removals
* Removed deprecated error codes. Fixes #4283
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use the imperative in changelog files
"Removed" -> "Remove"
"Fixes" -> "Fix"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

library/error.c Show resolved Hide resolved
include/mbedtls/psa_util.h Outdated
@@ -32,6 +32,10 @@
#include MBEDTLS_CONFIG_FILE
#endif

#if defined(MBEDTLS_PLATFORM_C)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is it needed here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No! Removing...

library/error.c Show resolved Hide resolved
@TRodziewicz
Update issue4283.txt
7bdbc45 
Corrections in the ChangeLog file after a review.
@TRodziewicz
Update psa_util.h
bfa03e3 
Remove the conditional include after the code review
mpg
mpg previously approved these changes Apr 22, 2021
View reviewed changes
Copy link
Contributor

@mpg mpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, however there are new conflicts. We you fix them by merging development_3.0 into your branch again? Then ping Mateusz and I, so that we re-review quickly and merge before other conflicts appear.

@mpg mpg added needs-work and removed needs-review Every commit must be reviewed by at least two team members, needs-reviewer This PR needs someone to pick it up for review labels Apr 22, 2021
@TRodziewicz TRodziewicz dismissed stale reviews from mpg and mstarzyk-mobica via 9a97a13 April 22, 2021 10:53
OBSOLETE - PLEASE SEE https://github.com/orgs/Mbed-TLS/projects/2 automation moved this from Has Approval to In Progress Apr 22, 2021
@TRodziewicz TRodziewicz added the needs-ci Needs to pass CI tests label Apr 22, 2021
mpg
mpg approved these changes Apr 22, 2021
View reviewed changes
Copy link
Contributor

@mpg mpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

OBSOLETE - PLEASE SEE https://github.com/orgs/Mbed-TLS/projects/2 automation moved this from In Progress to Has Approval Apr 22, 2021
@TRodziewicz TRodziewicz added approved Design and code approved - may be waiting for CI or backports and removed needs-ci Needs to pass CI tests labels Apr 22, 2021
@mpg mpg merged commit c102164 into Mbed-TLS:development_3.0 Apr 22, 2021
@gilles-peskine-arm gilles-peskine-arm mentioned this pull request Apr 23, 2021
Closed
daverodgman pushed a commit that referenced this pull request Apr 23, 2021
@mpg
Merge pull request #4339 from TRodziewicz/remove_depr_error_codes
d0b10c4 
Remove deprecated error codes.
@TRodziewicz TRodziewicz mentioned this pull request Apr 29, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpg mpg mpg approved these changes

@mstarzyk-mobica mstarzyk-mobica mstarzyk-mobica approved these changes

Assignees

@TRodziewicz TRodziewicz

Labels
approved Design and code approved - may be waiting for CI or backports size-s Estimated task size: small (~2d)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove deprecated error codes
5 participants
@TRodziewicz @mpg @mstarzyk-mobica @ronald-cron-arm @tomasz-rodziewicz-mobica